Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / d999ffc12211f5d5c6cd2196dd525e69e2fc0f58
commitd999ffc12211f5d5c6cd2196dd525e69e2fc0f58[log] [tgz]
authorVernon Mauery <vernon.mauery@linux.intel.com>Thu Oct 25 09:16:05 2018 -0700
committerVernon Mauery <vernon.mauery@linux.intel.com>Wed Nov 21 18:50:53 2018 +0000
treef79df7e8c5a2169048e8ed568fefae4912938f0c
parent127748a82ce1459a35d9886dc250697e78c24dd2 [diff]
netipmid: use shared_ptr on messages instead of unique_ptr+references

Messages were being created and held by unique_ptr objects and then
shared via reference. This is dangerous and sidesteps the whole point of
a unique_ptr, which is to enforce single ownership. This replaces the
usage with a shared_ptr, which denotes shared ownership.

Change-Id: I19ed2693f5a0f5ce47d720ed255fa05bdf3844f8
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
5 files changed
tree: f79df7e8c5a2169048e8ed568fefae4912938f0c
  1. command/
  2. sol/
  3. test/
  4. .clang-format
  5. .gitignore
  6. auth_algo.cpp
  7. auth_algo.hpp
  8. bootstrap.sh
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. configure.ac
  14. crypt_algo.cpp
  15. crypt_algo.hpp
  16. endian.hpp
  17. integrity_algo.cpp
  18. integrity_algo.hpp
  19. LICENSE
  20. main.cpp
  21. main.hpp
  22. MAINTAINERS
  23. Makefile.am
  24. message.hpp
  25. message_handler.cpp
  26. message_handler.hpp
  27. message_parsers.cpp
  28. message_parsers.hpp
  29. prng.hpp
  30. provider_registration.cpp
  31. provider_registration.hpp
  32. README.md
  33. rmcp.hpp
  34. sd_event_loop.cpp
  35. sd_event_loop.hpp
  36. session.hpp
  37. sessions_manager.cpp
  38. sessions_manager.hpp
  39. settings.cpp
  40. settings.hpp
  41. socket_channel.cpp
  42. socket_channel.hpp
  43. sol_module.cpp
  44. sol_module.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.