Fix: Incorrect max instance for get payload status
Response data byte 2 value for the get payload activation status cmd,
was 0x10 which is decoded as 0 instances activated since
bit 7:4 reserved.
Currently SOL payload is only supported and there can be 1 max sol
payload instance. This code provides fix for the same by correcting
sol payload instance capacity.
Tested:
Verified by issuing get payload status activation command through
ipmitool.
ipmitool -I lanplus -H <ip> -U xxxx -P xxxxxxx raw 0x06 0x4A 0x01
01 00 00 //Response
Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>
Change-Id: I874fe3fe784417c9460a1cee5bb5e6bc36291012
diff --git a/command/payload_cmds.cpp b/command/payload_cmds.cpp
index 8f573a8..219f2d5 100644
--- a/command/payload_cmds.cpp
+++ b/command/payload_cmds.cpp
@@ -208,7 +208,9 @@
}
response->completionCode = IPMI_CC_OK;
- response->capacity = MAX_PAYLOAD_INSTANCES;
+
+ constexpr size_t maxSolPayloadInstances = 1;
+ response->capacity = maxSolPayloadInstances;
// Currently we support only one SOL session
response->instance1 =
diff --git a/sol/sol_manager.hpp b/sol/sol_manager.hpp
index 5d96890..86d24d5 100644
--- a/sol/sol_manager.hpp
+++ b/sol/sol_manager.hpp
@@ -12,7 +12,6 @@
namespace sol
{
-constexpr size_t MAX_PAYLOAD_INSTANCES = 16;
constexpr size_t MAX_PAYLOAD_SIZE = 255;
constexpr uint8_t MAJOR_VERSION = 0x01;
constexpr uint8_t MINOR_VERSION = 0x00;