commit ec5ddaf5e5d4a7b6ecb6485957db26e76bd1a226
author Vernon Mauery <vernon.mauery@linux.intel.com> Wed Aug 03 11:00:50 2022 -0700
committer Vernon Mauery <vernon.mauery@linux.intel.com> Mon Aug 15 20:06:09 2022 +0000
tree b449bcc756aa5b5de596d2f085c652e00948dc1b
parent 7b7f25f70cdef22e626a41abe5bd8d950e14eff9

Fix issues found by a static code scan

* bitwise operands of different size
* uninitialized member variables

Tested: Builds and runs without difference.

Change-Id: Ie59f0b9ede0bad1840a16a092f310e3fb37d23da
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

message.hpp

diff --git a/message.hpp b/message.hpp
index b486c77..7902b1e 100644
--- a/message.hpp
+++ b/message.hpp
@@ -168,7 +168,7 @@
     {
         uint32_t command = 0;
 
-        command |= (static_cast<uint8_t>(payloadType) << 16);
+        command |= (static_cast<uint32_t>(payloadType) << 16);
         if (payloadType == PayloadType::IPMI)
         {
             auto request =

message_handler.hpp

diff --git a/message_handler.hpp b/message_handler.hpp
index 37e7240..f0d4848 100644
--- a/message_handler.hpp
+++ b/message_handler.hpp
@@ -148,10 +148,10 @@
 
     parser::SessionHeader sessionHeader = parser::SessionHeader::IPMI20;
 
-    std::shared_ptr<message::Message> inMessage;
+    std::shared_ptr<message::Message> inMessage{};
 
     /** @brief The IPMI session of the handler */
-    std::shared_ptr<session::Session> session;
+    std::shared_ptr<session::Session> session{};
 };
 
 } // namespace message