Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / 1d82b2270865cfd67faf94f7259484095dfdcba5
commit1d82b2270865cfd67faf94f7259484095dfdcba5[log] [tgz]
authorRichard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>Wed Jun 06 14:38:34 2018 +0530
committerRichard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>Sun Jul 08 22:20:21 2018 +0530
tree65bd93c0a5aadf7832e30a0868b1a3d864ad1802
parent57334929851dd0c4f6fd97a881e020594793246d [diff]
Fix to return sane error code

Any unhandled exception in the IPMI command handler
crashes the ipmi stack. IPMI command handler also becomes
bulky to catch all exceptions which must return unspecified
errors. This fix adds a catch in the ipmi router command handler
functions, and returns IPMI_CC_UNSPECIFIED_ERROR for all the
unhandled exceptions. With this fix, exceptions which has to
throw IPMI_CC_UNSPECIFIED_ERROR, doesn't needs to be handled in the
command handlers.

Change-Id: Icf8741925d857170b2f748906edbaf6cf1e55cdc
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
1 file changed
tree: 65bd93c0a5aadf7832e30a0868b1a3d864ad1802
  1. command/
  2. sol/
  3. test/
  4. .gitignore
  5. auth_algo.cpp
  6. auth_algo.hpp
  7. bootstrap.sh
  8. comm_module.cpp
  9. comm_module.hpp
  10. command_table.cpp
  11. command_table.hpp
  12. configure.ac
  13. crypt_algo.cpp
  14. crypt_algo.hpp
  15. endian.hpp
  16. integrity_algo.cpp
  17. integrity_algo.hpp
  18. LICENSE
  19. main.cpp
  20. main.hpp
  21. MAINTAINERS
  22. Makefile.am
  23. message.hpp
  24. message_handler.cpp
  25. message_handler.hpp
  26. message_parsers.cpp
  27. message_parsers.hpp
  28. provider_registration.cpp
  29. provider_registration.hpp
  30. README.md
  31. rmcp.hpp
  32. sd_event_loop.cpp
  33. sd_event_loop.hpp
  34. session.cpp
  35. session.hpp
  36. sessions_manager.cpp
  37. sessions_manager.hpp
  38. settings.cpp
  39. settings.hpp
  40. socket_channel.cpp
  41. socket_channel.hpp
  42. sol_module.cpp
  43. sol_module.hpp
  44. timer.cpp
  45. timer.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.