commit 150753f3d8b585a37f8886f06e0e034c1db66dfd
author William A. Kennington III <wak@google.com> Fri Aug 05 15:20:54 2022 -0700
committer William A. Kennington III <wak@google.com> Tue Sep 20 13:27:59 2022 -0700
tree 619ca2a3473c31aa1cf5812d11a4d08ab47f3ef5
parent bc52d93d62ddc9bbf6dcea6e16b16945f4e6e5a3

config_parser: Add common boolean parser

This more accurately parses systemd values instead of just comparing to
"false" or "true".

Change-Id: I0d70ef418075d555bf6f090fefa0b34332491ed0
Signed-off-by: William A. Kennington III <wak@google.com>

src/dhcp_configuration.cpp

diff --git a/src/dhcp_configuration.cpp b/src/dhcp_configuration.cpp
index 0605a6a..ec9e6d9 100644
--- a/src/dhcp_configuration.cpp
+++ b/src/dhcp_configuration.cpp
@@ -98,7 +98,14 @@
         log<level::NOTICE>(msg.c_str(), entry("PROP=%s", prop.c_str()));
         return true;
     }
-    return values.back() != "false";
+    auto ret = config::parseBool(values.back());
+    if (!ret.has_value())
+    {
+        auto msg = fmt::format("Failed to parse section DHCP[{}]: `{}`", prop,
+                               values.back());
+        log<level::NOTICE>(msg.c_str(), entry("PROP=%s", prop.c_str()));
+    }
+    return ret.value_or(true);
 }
 } // namespace dhcp
 } // namespace network