commit 166b9598ac83db574c4e9b666e770b76f3501b29
author Patrick Williams <patrick@stwcx.xyz> Wed Mar 30 16:09:16 2022 -0500
committer Patrick Williams <patrick@stwcx.xyz> Wed Mar 30 16:09:40 2022 -0500
tree 218df32ae4ca5dd254b6622a2d926b05b87eb497
parent 3397be3ca10310a264ee0ab9c5fb17add9e0307b

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications.  Map all `true` occurrences to
`action::defer_emit`.

Change-Id: I2e7ce5e279d65d101e1249f2b41f126143d3f03d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

src/dhcp_configuration.hpp

diff --git a/src/dhcp_configuration.hpp b/src/dhcp_configuration.hpp
index c4a06a9..272959a 100644
--- a/src/dhcp_configuration.hpp
+++ b/src/dhcp_configuration.hpp
@@ -44,7 +44,7 @@
      */
     Configuration(sdbusplus::bus::bus& bus, const std::string& objPath,
                   Manager& parent) :
-        Iface(bus, objPath.c_str(), true),
+        Iface(bus, objPath.c_str(), Iface::action::defer_emit),
         bus(bus), manager(parent)
     {
         ConfigIntf::dnsEnabled(getDHCPPropFromConf("UseDNS"));

src/ethernet_interface.cpp

diff --git a/src/ethernet_interface.cpp b/src/ethernet_interface.cpp
index 3da9a57..864e252 100644
--- a/src/ethernet_interface.cpp
+++ b/src/ethernet_interface.cpp
@@ -64,7 +64,9 @@
                                      DHCPConf dhcpEnabled, Manager& parent,
                                      bool emitSignal,
                                      std::optional<bool> enabled) :
-    Ifaces(bus, objPath.c_str(), true),
+    Ifaces(bus, objPath.c_str(),
+           emitSignal ? Ifaces::action::defer_emit
+                      : Ifaces::action::emit_no_signals),
     bus(bus), manager(parent), objPath(objPath)
 {
     auto intfName = objPath.substr(objPath.rfind("/") + 1);

src/ipaddress.cpp

diff --git a/src/ipaddress.cpp b/src/ipaddress.cpp
index f30cf34..0af0756 100644
--- a/src/ipaddress.cpp
+++ b/src/ipaddress.cpp
@@ -22,7 +22,7 @@
                      EthernetInterface& parent, IP::Protocol type,
                      const std::string& ipaddress, IP::AddressOrigin origin,
                      uint8_t prefixLength, const std::string& gateway) :
-    IPIfaces(bus, objPath, true),
+    IPIfaces(bus, objPath, IPIfaces::action::defer_emit),
     parent(parent)
 {
 

src/neighbor.cpp

diff --git a/src/neighbor.cpp b/src/neighbor.cpp
index 11b0666..c1f8fac 100644
--- a/src/neighbor.cpp
+++ b/src/neighbor.cpp
@@ -88,7 +88,7 @@
 Neighbor::Neighbor(sdbusplus::bus::bus& bus, const char* objPath,
                    EthernetInterface& parent, const std::string& ipAddress,
                    const std::string& macAddress, State state) :
-    NeighborObj(bus, objPath, true),
+    NeighborObj(bus, objPath, NeighborObj::action::defer_emit),
     parent(parent)
 {
     this->ipAddress(ipAddress);

src/network_manager.cpp

diff --git a/src/network_manager.cpp b/src/network_manager.cpp
index a9ff7cc..b2ca45d 100644
--- a/src/network_manager.cpp
+++ b/src/network_manager.cpp
@@ -41,7 +41,8 @@
 
 Manager::Manager(sdbusplus::bus::bus& bus, const char* objPath,
                  const std::string& path) :
-    details::VLANCreateIface(bus, objPath, true),
+    details::VLANCreateIface(bus, objPath,
+                             details::VLANCreateIface::action::defer_emit),
     bus(bus), objectPath(objPath)
 {
     fs::path confDir(path);

src/system_configuration.cpp

diff --git a/src/system_configuration.cpp b/src/system_configuration.cpp
index d1c1ed0..ae7d270 100644
--- a/src/system_configuration.cpp
+++ b/src/system_configuration.cpp
@@ -31,7 +31,7 @@
 SystemConfiguration::SystemConfiguration(sdbusplus::bus::bus& bus,
                                          const std::string& objPath,
                                          Manager& parent) :
-    Iface(bus, objPath.c_str(), true),
+    Iface(bus, objPath.c_str(), Iface::action::defer_emit),
     bus(bus), manager(parent)
 {
     auto name = getHostNameFromSystem();