config_parser: Cleanups and modern c++ standards
This was exposing many functions and semantics that are unused by the
application. The goal is to simplify the interface and convert to using
types like `string_view` and referenceable lists where possible.
Change-Id: I4cba6326f9a96a943d384165e656f8589f931959
Signed-off-by: William A. Kennington III <wak@google.com>
diff --git a/test/test_ethernet_interface.cpp b/test/test_ethernet_interface.cpp
index 24fe5fb..0fd2444 100644
--- a/test/test_ethernet_interface.cpp
+++ b/test/test_ethernet_interface.cpp
@@ -162,10 +162,7 @@
fs::path filePath = confDir;
filePath /= "00-bmc-test0.network";
config::Parser parser(filePath.string());
- config::ReturnCode rc = config::ReturnCode::SUCCESS;
- config::ValueList values;
- std::tie(rc, values) = parser.getValues("Network", "DNS");
- EXPECT_EQ(servers, values);
+ EXPECT_EQ(servers, parser.getValues("Network", "DNS"));
}
TEST_F(TestEthernetInterface, addDynamicNameServers)
@@ -191,10 +188,7 @@
fs::path filePath = confDir;
filePath /= "00-bmc-test0.network";
config::Parser parser(filePath.string());
- config::ReturnCode rc = config::ReturnCode::SUCCESS;
- config::ValueList values;
- std::tie(rc, values) = parser.getValues("Network", "NTP");
- EXPECT_EQ(servers, values);
+ EXPECT_EQ(servers, parser.getValues("Network", "NTP"));
}
TEST_F(TestEthernetInterface, addGateway)