commit 2a846b3e5834419c4e42ae1e0ced03a76ad27a9d
author William A. Kennington III <wak@google.com> Thu Sep 01 13:13:13 2022 -0700
committer William A. Kennington III <wak@google.com> Thu Sep 01 14:30:58 2022 -0700
tree d8fd6b52b50f0ef76e2807e17feec2c1683b39b3
parent 5e72d085356a066521ff1e7b62dbe2820b659993

ethernet_interface: Remove nameserver setting

Now made readonly in the interface.

Change-Id: I8a90648096d649d5cb93bb688599e553cf15dabd
Signed-off-by: William A. Kennington III <wak@google.com>

src/ethernet_interface.cpp

diff --git a/src/ethernet_interface.cpp b/src/ethernet_interface.cpp
index 825ce62..90c987d 100644
--- a/src/ethernet_interface.cpp
+++ b/src/ethernet_interface.cpp
@@ -762,12 +762,6 @@
     return value;
 }
 
-ServerList EthernetInterface::nameservers(ServerList /*value*/)
-{
-    elog<NotAllowed>(NotAllowedArgument::REASON("ReadOnly Property"));
-    return EthernetInterfaceIntf::nameservers();
-}
-
 ServerList EthernetInterface::staticNameServers(ServerList value)
 {
     for (const auto& nameserverip : value)

src/ethernet_interface.hpp

diff --git a/src/ethernet_interface.hpp b/src/ethernet_interface.hpp
index 592d690..751c74a 100644
--- a/src/ethernet_interface.hpp
+++ b/src/ethernet_interface.hpp
@@ -199,11 +199,6 @@
      */
     ServerList ntpServers(ServerList value) override;
 
-    /** @brief sets the DNS/nameservers.
-     *  @param[in] value - vector of DNS servers.
-     */
-    ServerList nameservers(ServerList value) override;
-
     /** @brief sets the Static DNS/nameservers.
      *  @param[in] value - vector of DNS servers.
      */

test/test_ethernet_interface.cpp

diff --git a/test/test_ethernet_interface.cpp b/test/test_ethernet_interface.cpp
index 0fd2444..96f00d1 100644
--- a/test/test_ethernet_interface.cpp
+++ b/test/test_ethernet_interface.cpp
@@ -13,7 +13,6 @@
 #include <fstream>
 #include <sdbusplus/bus.hpp>
 #include <stdplus/gtest/tmp.hpp>
-#include <xyz/openbmc_project/Common/error.hpp>
 
 #include <gtest/gtest.h>
 
@@ -165,13 +164,6 @@
     EXPECT_EQ(servers, parser.getValues("Network", "DNS"));
 }
 
-TEST_F(TestEthernetInterface, addDynamicNameServers)
-{
-    using namespace sdbusplus::xyz::openbmc_project::Common::Error;
-    ServerList servers = {"9.1.1.1", "9.2.2.2", "9.3.3.3"};
-    EXPECT_THROW(interface.nameservers(servers), NotAllowed);
-}
-
 TEST_F(TestEthernetInterface, getDynamicNameServers)
 {
     ServerList servers = {"9.1.1.1", "9.2.2.2", "9.3.3.3"};