Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-networkd / 2ea71fa3dcc5e3b04535ff105815034fdc16799b
commit2ea71fa3dcc5e3b04535ff105815034fdc16799b[log] [tgz]
authorManojkiran Eda <manojkiran.eda@gmail.com>Sat Oct 10 08:23:54 2020 +0530
committerManojKiran Eda <manojkiran.eda@gmail.com>Thu Apr 15 01:55:36 2021 +0000
tree092b0bb12d116c2ea230fca3f1eea5f083e837c9
parent4d94ecd8aae775f243cd73c78efb5cf657852e48 [diff]
Fix shell check errors & enforce it in CI

- CI already has infrastructure to enfore shell check errors
  but it was not leveraged as the repo does not have a .shellcheck
  file.

- CI always throws the below warning in every CI

In bootstrap.sh line 11:
find -name "$file" | xargs -r rm -rf
^----------------^ SC2038: Use -print0/-0 or -exec + to allow for non-alphanumeric filenames.
^--^ SC2185: Some finds don't have a default path. Specify '.' explicitly.

In bootstrap.sh line 18:
echo 'Run "./configure ${CONFIGURE_FLAGS} && make"'
-- SC2016: Expressions don't expand in single quotes, use double quotes for that.

- Fixed SC2185,SC2038 and supressed SC2016 shell check errors.
  more information regarding this errors are found at
  https://github.com/koalaman/shellcheck/wiki/

TestedBy:
https://www.shellcheck.net/

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I1323741fc8ea344b6ea4e7cdf2c1b87bb8611523
2 files changed
tree: 092b0bb12d116c2ea230fca3f1eea5f083e837c9
  1. docs/
  2. test/
  3. xyz/
  4. .clang-format
  5. .gitignore
  6. .shellcheck
  7. argument.cpp
  8. argument.hpp
  9. bootstrap.sh
  10. config_parser.cpp
  11. config_parser.hpp
  12. configure.ac
  13. dhcp_configuration.cpp
  14. dhcp_configuration.hpp
  15. dns_updater.cpp
  16. dns_updater.hpp
  17. ethernet_interface.cpp
  18. ethernet_interface.hpp
  19. ipaddress.cpp
  20. ipaddress.hpp
  21. LICENSE
  22. MAINTAINERS
  23. Makefile.am
  24. ncsi_netlink_main.cpp
  25. ncsi_util.cpp
  26. ncsi_util.hpp
  27. neighbor.cpp
  28. neighbor.hpp
  29. netlink.cpp
  30. netlink.hpp
  31. network_config.cpp
  32. network_config.hpp
  33. network_manager.cpp
  34. network_manager.hpp
  35. network_manager_main.cpp
  36. README.md
  37. routing_table.cpp
  38. routing_table.hpp
  39. rtnetlink_server.cpp
  40. rtnetlink_server.hpp
  41. system_configuration.cpp
  42. system_configuration.hpp
  43. types.hpp
  44. util.cpp
  45. util.hpp
  46. vlan_interface.cpp
  47. vlan_interface.hpp
  48. watch.cpp
  49. watch.hpp
  50. xyz.openbmc_project.Network.conf.in
  51. xyz.openbmc_project.Network.service.in
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.