commit 2fd2f7da682486aa0594eb99fae167c9eb459940
author Ravi Teja <raviteja28031990@gmail.com> Thu Jun 06 03:27:55 2019 -0500
committer Ravi Teja <raviteja28031990@gmail.com> Thu Jul 11 05:46:04 2019 +0000
tree 41bfbe6beb7bb3834b08dad1f53abb47923b5921
parent f51620ddfa4fe338db61aac63a6a83d5f12b7e03

Network: Remove IP dbus properties update support

Currently, we support IP object properties update,
it just update dbus object, actually it wont change
properties on ethernet interface.

Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>
Change-Id: I60fdc2e07cdb728d661dd0baf1bbba8f7fff3702

ipaddress.cpp

diff --git a/ipaddress.cpp b/ipaddress.cpp
index 43433e2..f983975 100644
--- a/ipaddress.cpp
+++ b/ipaddress.cpp
@@ -8,7 +8,6 @@
 #include <phosphor-logging/elog-errors.hpp>
 #include <phosphor-logging/log.hpp>
 #include <xyz/openbmc_project/Common/error.hpp>
-
 namespace phosphor
 {
 namespace network
@@ -16,6 +15,8 @@
 
 using namespace phosphor::logging;
 using namespace sdbusplus::xyz::openbmc_project::Common::Error;
+using NotAllowed = sdbusplus::xyz::openbmc_project::Common::Error::NotAllowed;
+using Reason = xyz::openbmc_project::Common::NotAllowed::REASON;
 
 IPAddress::IPAddress(sdbusplus::bus::bus& bus, const char* objPath,
                      EthernetInterface& parent, IP::Protocol type,
@@ -24,16 +25,36 @@
     IPIfaces(bus, objPath, true),
     parent(parent)
 {
-    this->address(ipaddress);
-    this->prefixLength(prefixLength);
-    this->gateway(gateway);
-    this->type(type);
-    this->origin(origin);
+
+    IP::address(ipaddress);
+    IP::prefixLength(prefixLength);
+    IP::gateway(gateway);
+    IP::type(type);
+    IP::origin(origin);
 
     // Emit deferred signal.
     emit_object_added();
 }
-
+std::string IPAddress::address(std::string ipAddress)
+{
+    elog<NotAllowed>(Reason("Property update is not allowed"));
+}
+uint8_t IPAddress::prefixLength(uint8_t value)
+{
+    elog<NotAllowed>(Reason("Property update is not allowed"));
+}
+std::string IPAddress::gateway(std::string gateway)
+{
+    elog<NotAllowed>(Reason("Property update is not allowed"));
+}
+IP::Protocol IPAddress::type(IP::Protocol type)
+{
+    elog<NotAllowed>(Reason("Property update is not allowed"));
+}
+IP::AddressOrigin IPAddress::origin(IP::AddressOrigin origin)
+{
+    elog<NotAllowed>(Reason("Property update is not allowed"));
+}
 void IPAddress::delete_()
 {
     if (parent.dHCPEnabled())

ipaddress.hpp

diff --git a/ipaddress.hpp b/ipaddress.hpp
index b0e77fb..3ed551a 100644
--- a/ipaddress.hpp
+++ b/ipaddress.hpp
@@ -50,10 +50,22 @@
               const std::string& ipAddress, IP::AddressOrigin origin,
               uint8_t prefixLength, const std::string& gateway);
 
+    std::string address(std::string ipAddress) override;
+    uint8_t prefixLength(uint8_t) override;
+    std::string gateway(std::string gateway) override;
+    IP::Protocol type(IP::Protocol type) override;
+    IP::AddressOrigin origin(IP::AddressOrigin origin) override;
+
     /** @brief Delete this d-bus object.
      */
     void delete_() override;
 
+    using IP::address;
+    using IP::gateway;
+    using IP::origin;
+    using IP::prefixLength;
+    using IP::type;
+
   private:
     /** @brief Parent Object. */
     EthernetInterface& parent;