Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-networkd / 33bc9a93601059c7baffb3f8527f636cad9f8ae5
commit33bc9a93601059c7baffb3f8527f636cad9f8ae5[log] [tgz]
authorAsmitha Karunanithi <asmitk01@in.ibm.com>Thu Aug 13 08:48:33 2020 -0500
committerAsmitha Karunanithi <asmitk01@in.ibm.com>Mon Aug 31 10:41:37 2020 -0500
tree6887fa1d5c202d4f0d3098fc5cb9073ddfa675d8
parent76b2aa3e7e0cc85b49b0c0d2f9403f80b2c4f8ab [diff]
Fix for not updating invalid MAC to fw_printenv

Invalid MAC was written to the Firmware env on updates.

The current implementation fails to write the trimmed address
for the following testcases:
* AA:FF:FF:FF:FF:100
* AA:AA:AA:AA:AA:AA:BB

Tested-By:

AA:E2:84:14:28:79    -    Valid

AA:FF:FF:FF:FF:100   -    Out of Range MAC
    * This will be written as "AA:FF:FF:FF:FF:10"

AA:AA:AA:AA:AA:AA:BB -    MAC with more tha 6 bytes
    * This will be written as "AA:AA:AA:AA:AA:AA"

a:b:c:d:e:f          -    This will be written as
                          "0a:0b:0c:0d:0e:0f"

0a:0b:0c:0d:0e:0f    -    This will be written as
                          "0a:0b:0c:0d:0e:0f"

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I9141365590df05823f0d277a16e01132a3326267
1 file changed
tree: 6887fa1d5c202d4f0d3098fc5cb9073ddfa675d8
  1. docs/
  2. test/
  3. xyz/
  4. .clang-format
  5. .gitignore
  6. argument.cpp
  7. argument.hpp
  8. bootstrap.sh
  9. config_parser.cpp
  10. config_parser.hpp
  11. configure.ac
  12. dhcp_configuration.cpp
  13. dhcp_configuration.hpp
  14. dns_updater.cpp
  15. dns_updater.hpp
  16. ethernet_interface.cpp
  17. ethernet_interface.hpp
  18. ipaddress.cpp
  19. ipaddress.hpp
  20. LICENSE
  21. MAINTAINERS
  22. Makefile.am
  23. ncsi_netlink_main.cpp
  24. ncsi_util.cpp
  25. ncsi_util.hpp
  26. neighbor.cpp
  27. neighbor.hpp
  28. netlink.cpp
  29. netlink.hpp
  30. network_config.cpp
  31. network_config.hpp
  32. network_manager.cpp
  33. network_manager.hpp
  34. network_manager_main.cpp
  35. README.md
  36. routing_table.cpp
  37. routing_table.hpp
  38. rtnetlink_server.cpp
  39. rtnetlink_server.hpp
  40. system_configuration.cpp
  41. system_configuration.hpp
  42. types.hpp
  43. util.cpp
  44. util.hpp
  45. vlan_interface.cpp
  46. vlan_interface.hpp
  47. watch.cpp
  48. watch.hpp
  49. xyz.openbmc_project.Network.conf.in
  50. xyz.openbmc_project.Network.service.in
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.