commit 35297177b81061c3ac6658412c6306556849790a
author Ratan Gupta <ratagupt@linux.vnet.ibm.com> Wed Nov 28 18:40:16 2018 +0530
committer Ratan Gupta <ratagupt@linux.vnet.ibm.com> Fri Nov 30 20:42:02 2018 +0530
tree 9a2a63e74cf4cb2930bca7587fef91f855e8aa0e
parent 450b346910a7bcf9abde55d76693539a83bf33f7

Re-enable unit test

Unit test were broken after sd bus calls started throwing exception,
In this repo we start the systemd-networkd with the use of sd bus
calls, which throws exception and it was not handled in the test case.

This commit fixes the problem by mocking the network manager which
mock the functionality of function which makes the sdbus call.

Change-Id: I5b60a2117a661cffa36200415ca611b85dd2fda1
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>

test/test_rtnetlink.cpp

diff --git a/test/test_rtnetlink.cpp b/test/test_rtnetlink.cpp
index ee43bf4..9284600 100644
--- a/test/test_rtnetlink.cpp
+++ b/test/test_rtnetlink.cpp
@@ -1,5 +1,5 @@
+#include "mock_network_manager.hpp"
 #include "mock_syscall.hpp"
-#include "network_manager.hpp"
 #include "rtnetlink_server.hpp"
 #include "types.hpp"
 
@@ -19,9 +19,9 @@
 namespace network
 {
 sdbusplus::bus::bus bus(sdbusplus::bus::new_default());
-std::unique_ptr<Manager> manager = nullptr;
-std::unique_ptr<Timer> refreshObjectTimer = nullptr;
-std::unique_ptr<Timer> restartTimer = nullptr;
+std::unique_ptr<MockManager> manager = nullptr;
+extern std::unique_ptr<Timer> refreshObjectTimer;
+extern std::unique_ptr<Timer> restartTimer;
 EventPtr eventPtr = nullptr;
 
 /** @brief refresh the network objects. */
@@ -50,7 +50,7 @@
     TestRtNetlink()
     {
         manager =
-            std::make_unique<Manager>(bus, "/xyz/openbmc_test/bcd", "/tmp");
+            std::make_unique<MockManager>(bus, "/xyz/openbmc_test/bcd", "/tmp");
         sd_event* events;
         sd_event_default(&events);
         eventPtr.reset(events);