commit 4ee7a7ea1a2d9d229330861a34ea41306611d661
author William A. Kennington III <wak@google.com> Tue Oct 11 16:37:22 2022 -0700
committer William A. Kennington III <wak@google.com> Tue Oct 25 03:24:38 2022 -0700
tree c521222f1501910eb6ac2e47faab8ac27d44d4f5
parent 962218016eebe6cc790d73fde8bc0d61d3ea8fb9

ethernet_interface: Refactor ethtool querying

This simplifies the amount of parameters pulled and unpacking procedure.

Change-Id: I2991534aeb0fbdda20d4c9b262c1f1a80bf518f8
Signed-off-by: William A. Kennington III <wak@google.com>

src/ethernet_interface.hpp

diff --git a/src/ethernet_interface.hpp b/src/ethernet_interface.hpp
index 8826ce8..578fc5b 100644
--- a/src/ethernet_interface.hpp
+++ b/src/ethernet_interface.hpp
@@ -37,6 +37,8 @@
 using ServerList = std::vector<std::string>;
 using ObjectPath = sdbusplus::message::object_path;
 
+using VlanId = uint32_t;
+
 class Manager;
 
 class TestEthernetInterface;
@@ -48,17 +50,6 @@
 class Parser;
 }
 
-using LinkSpeed = uint16_t;
-using DuplexMode = uint8_t;
-using Autoneg = uint8_t;
-using LinkUp = bool;
-using NICEnabled = bool;
-using MTU = size_t;
-using VlanId = uint32_t;
-using InterfaceName = std::string;
-using InterfaceInfo =
-    std::tuple<LinkSpeed, DuplexMode, Autoneg, LinkUp, NICEnabled, MTU>;
-
 /** @class EthernetInterface
  *  @brief OpenBMC Ethernet Interface implementation.
  *  @details A concrete implementation for the
@@ -235,11 +226,6 @@
     using EthernetInterfaceIntf::defaultGateway6;
 
   protected:
-    /** @brief get the info of the ethernet interface.
-     *  @return tuple having the link speed,autonegotiation,duplexmode .
-     */
-    InterfaceInfo getInterfaceInfo() const;
-
     /* @brief delete the vlan interface from system.
      * @param[in] interface - vlan Interface.
      */