commit 5e72d085356a066521ff1e7b62dbe2820b659993
author William A. Kennington III <wak@google.com> Thu Sep 01 13:10:17 2022 -0700
committer William A. Kennington III <wak@google.com> Thu Sep 01 13:13:42 2022 -0700
tree 5cfac2803715e6e4d9d349aefddec403ff5dee0f
parent d9e2d72c9d43b53cec20597cd133ef746efd6db1

Revert "ipaddress: Remove set property overrides"

This reverts commit a809f92e05bfbb07414a77cda64d5d75f3ad1bce.

This was overly optimistic and we need to keep the exception paths.

Change-Id: If17d74a4af964eff6d2d14ca42402d8190f54484
Signed-off-by: William A. Kennington III <wak@google.com>

src/ipaddress.cpp

diff --git a/src/ipaddress.cpp b/src/ipaddress.cpp
index 85e5bca..becb5b3 100644
--- a/src/ipaddress.cpp
+++ b/src/ipaddress.cpp
@@ -37,6 +37,8 @@
 
 using namespace phosphor::logging;
 using namespace sdbusplus::xyz::openbmc_project::Common::Error;
+using NotAllowed = sdbusplus::xyz::openbmc_project::Common::Error::NotAllowed;
+using Reason = xyz::openbmc_project::Common::NotAllowed::REASON;
 
 IPAddress::IPAddress(sdbusplus::bus_t& bus, const char* objPath,
                      EthernetInterface& parent, IP::Protocol type,
@@ -55,7 +57,26 @@
     // Emit deferred signal.
     emit_object_added();
 }
-
+std::string IPAddress::address(std::string /*ipAddress*/)
+{
+    elog<NotAllowed>(Reason("Property update is not allowed"));
+}
+uint8_t IPAddress::prefixLength(uint8_t /*value*/)
+{
+    elog<NotAllowed>(Reason("Property update is not allowed"));
+}
+std::string IPAddress::gateway(std::string /*gateway*/)
+{
+    elog<NotAllowed>(Reason("Property update is not allowed"));
+}
+IP::Protocol IPAddress::type(IP::Protocol /*type*/)
+{
+    elog<NotAllowed>(Reason("Property update is not allowed"));
+}
+IP::AddressOrigin IPAddress::origin(IP::AddressOrigin /*origin*/)
+{
+    elog<NotAllowed>(Reason("Property update is not allowed"));
+}
 void IPAddress::delete_()
 {
     if (origin() != IP::AddressOrigin::Static)

src/ipaddress.hpp

diff --git a/src/ipaddress.hpp b/src/ipaddress.hpp
index 0047d11..b46d64e 100644
--- a/src/ipaddress.hpp
+++ b/src/ipaddress.hpp
@@ -81,6 +81,12 @@
               const std::string& ipAddress, IP::AddressOrigin origin,
               uint8_t prefixLength, const std::string& gateway);
 
+    std::string address(std::string ipAddress) override;
+    uint8_t prefixLength(uint8_t) override;
+    std::string gateway(std::string gateway) override;
+    IP::Protocol type(IP::Protocol type) override;
+    IP::AddressOrigin origin(IP::AddressOrigin origin) override;
+
     /** @brief Delete this d-bus object.
      */
     void delete_() override;