commit 7784856dbf8dbc6bb4c4ab1caaa138e79f877c50
author William A. Kennington III <wak@google.com> Wed Oct 26 17:32:57 2022 -0700
committer William A. Kennington III <wak@google.com> Sat Nov 05 22:57:17 2022 -0700
tree 42da30f86e4aa742504355f2fff1a2e7e6cbd539
parent fd862be82cfc6439ef519ce8e2dcc6445d80c83f

test: Make mock syscalls take InterfaceInfo

This will make it easier to expand the parameters and plumb data through
the mock.

Change-Id: I5ca015a0494c092d9d247bbb2b7d0122c5e58fd8
Signed-off-by: William A. Kennington III <wak@google.com>

test/test_network_manager.cpp

diff --git a/test/test_network_manager.cpp b/test/test_network_manager.cpp
index 5298719..459bacf 100644
--- a/test/test_network_manager.cpp
+++ b/test/test_network_manager.cpp
@@ -28,6 +28,7 @@
         bus(sdbusplus::bus::new_default()),
         manager(bus, "/xyz/openbmc_test/abc", CaseTmpDir())
     {
+        system::mock_clear();
     }
 
     void createInterfaces()
@@ -39,17 +40,14 @@
 // getifaddrs will not return any interface
 TEST_F(TestNetworkManager, NoInterface)
 {
-    mock_clear();
     createInterfaces();
     EXPECT_TRUE(manager.getInterfaces().empty());
 }
 // getifaddrs returns single interface.
 TEST_F(TestNetworkManager, WithSingleInterface)
 {
-    mock_clear();
-
     // Adds the following ip in the getifaddrs list.
-    mock_addIF("igb1", /*idx=*/2);
+    system::mock_addIF({.idx = 2, .flags = 0, .name = "igb1"});
 
     // Now create the interfaces which will call the mocked getifaddrs
     // which returns the above interface detail.
@@ -60,10 +58,8 @@
 // getifaddrs returns two interfaces.
 TEST_F(TestNetworkManager, WithMultipleInterfaces)
 {
-    mock_clear();
-
-    mock_addIF("igb0", /*idx=*/1);
-    mock_addIF("igb1", /*idx=*/2);
+    system::mock_addIF({.idx = 1, .flags = 0, .name = "igb0"});
+    system::mock_addIF({.idx = 2, .flags = 0, .name = "igb1"});
 
     createInterfaces();
     EXPECT_THAT(manager.getInterfaces(),