commit 7ed1b286ae1620dd629d8cee8ae33ac4f7c53ecf
author William A. Kennington III <wak@google.com> Sun Apr 21 23:38:42 2019 -0700
committer William A. Kennington III <wak@google.com> Tue Jul 23 13:38:02 2019 -0700
tree fa6e7199c89ba9fa086e54299e810bb0ad480b76
parent 5bb7da9540d0cf52c2a6bc4cdb12a2d01a0d5193

ethernet_interface: Emit error when missing MAC

Now that our MAC address is being mocked in our test suite we can
actually error out when the HWADDR info is missing.

Change-Id: I84ac492774ba026194dc90c53f64aa63d9a3b1ca
Signed-off-by: William A. Kennington III <wak@google.com>

ethernet_interface.cpp

diff --git a/ethernet_interface.cpp b/ethernet_interface.cpp
index 4acbdc5..82be20e 100644
--- a/ethernet_interface.cpp
+++ b/ethernet_interface.cpp
@@ -268,7 +268,7 @@
     {
         log<level::ERR>("socket creation  failed:",
                         entry("ERROR=%s", strerror(errno)));
-        return "";
+        elog<InternalFailure>();
     }
 
     std::strcpy(ifr.ifr_name, interfaceName.c_str());
@@ -276,7 +276,7 @@
     {
         log<level::ERR>("ioctl failed for SIOCGIFHWADDR:",
                         entry("ERROR=%s", strerror(errno)));
-        return "";
+        elog<InternalFailure>();
     }
 
     static_assert(sizeof(ifr.ifr_hwaddr.sa_data) >= sizeof(ether_addr));