Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-networkd / 40a51df94c7668bf4de8f82b8c578c4a3b409974
commit40a51df94c7668bf4de8f82b8c578c4a3b409974[log] [tgz]
authorRatan Gupta <ratagupt@linux.vnet.ibm.com>Fri Apr 24 15:11:05 2020 +0530
committerRatan Gupta <ratagupt@linux.vnet.ibm.com>Fri Apr 24 15:39:43 2020 +0530
tree77525c154da004680db3799f82721c7e5d6b55b0
parent613a0129759a9408cef4bafec6e837323866e952 [diff]
Fix for the MAC address configuration

This bug was introduced with the commit d0679f9bb46670c593061c4aaebec2a577cdd5c3
where we enable the support for enabling/disabling the ethernet interface.

This breaks the mac address configuration where during setting of the mac
address requires the device should be down and then write the configuration file.

In write configuration file function, NIC status was checked directly from system
instead of looking at the D-bus values, as the interface was down during setting
of the MAC address, the check for looking at nic enabled status returns false
and it sets the Link status as "unmanged=yes" which stops the systemd-networkd
to configure this interface.

This commit fixes this behaviour by reading the nic status directly from the
D-bus objects.

I don't see a case where D-bus object value and the system given value is
not same as interface down/up is manual action.

TestedBy:
         Configure MAC address
         Configure NIC enabled up/down
         Configure IP address

Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>
Change-Id: Ib7c578c06ce930e39c2925d729da4d08c5367899
1 file changed
tree: 77525c154da004680db3799f82721c7e5d6b55b0
  1. docs/
  2. test/
  3. xyz/
  4. .clang-format
  5. .gitignore
  6. argument.cpp
  7. argument.hpp
  8. bootstrap.sh
  9. config_parser.cpp
  10. config_parser.hpp
  11. configure.ac
  12. dhcp_configuration.cpp
  13. dhcp_configuration.hpp
  14. dns_updater.cpp
  15. dns_updater.hpp
  16. ethernet_interface.cpp
  17. ethernet_interface.hpp
  18. ipaddress.cpp
  19. ipaddress.hpp
  20. LICENSE
  21. MAINTAINERS
  22. Makefile.am
  23. ncsi_netlink_main.cpp
  24. ncsi_util.cpp
  25. ncsi_util.hpp
  26. neighbor.cpp
  27. neighbor.hpp
  28. netlink.cpp
  29. netlink.hpp
  30. network_config.cpp
  31. network_config.hpp
  32. network_manager.cpp
  33. network_manager.hpp
  34. network_manager_main.cpp
  35. README.md
  36. routing_table.cpp
  37. routing_table.hpp
  38. rtnetlink_server.cpp
  39. rtnetlink_server.hpp
  40. system_configuration.cpp
  41. system_configuration.hpp
  42. types.hpp
  43. util.cpp
  44. util.hpp
  45. vlan_interface.cpp
  46. vlan_interface.hpp
  47. watch.cpp
  48. watch.hpp
  49. xyz.openbmc_project.Network.conf.in
  50. xyz.openbmc_project.Network.service.in
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.