commit 98fc5881eefde10312b057eaed659f8d3138efa4
author Nagaraju Goruganti <ngorugan@in.ibm.com> Tue Oct 31 04:40:12 2017 -0500
committer Brad Bishop <bradleyb@fuzziesquirrel.com> Mon Nov 06 18:12:21 2017 +0000
tree 4a48bc7b4cadd6bd73deb2a50ca16b48dfa83a37
parent d75f0497cd92042d4e2dba8662df9ff7e661d0be

Fix MAC Address validation

MAC Address validate method is retruning true for address:
00:00:00:00:00:00 which is an invalid address.

Resolves openbmc/openbmc#2333

Change-Id: Ida6c84855abeb11c95673087a8b361f151b0a3bc
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

util.hpp

diff --git a/util.hpp b/util.hpp
index 7e48383..de0221a 100644
--- a/util.hpp
+++ b/util.hpp
@@ -17,6 +17,7 @@
 constexpr auto IPV6_MAX_PREFIX_LENGTH = 64;
 constexpr auto IPV4_PREFIX = "169.254";
 constexpr auto IPV6_PREFIX = "fe80";
+constexpr auto ZEROMACADDRESS = "00:00:00:00:00:00";
 
 namespace mac_address
 {
@@ -35,7 +36,8 @@
 inline bool validate(const std::string& value)
 {
     std::regex regexToCheck(regex);
-    return std::regex_search(value, regexToCheck);
+    return std::regex_search(value, regexToCheck) &&
+           value.find(ZEROMACADDRESS) != 0;
 }
 
 /** @brief gets the MAC address from the Inventory.