commit 9ecb90eb20b1735deef8e3dbc25963d5cf8453f1
author William A. Kennington III <wak@google.com> Fri Oct 14 03:12:43 2022 -0700
committer William A. Kennington III <wak@google.com> Tue Oct 25 03:24:38 2022 -0700
tree 9cf6888b4a31f6e92e0eb0030e5dff836464cd5d
parent 4ee7a7ea1a2d9d229330861a34ea41306611d661

test/ethernet_interface: Improve syscall test coverage

Change-Id: Ia71a030f2e2e19f2cc191992929ef08d0fa917c2
Signed-off-by: William A. Kennington III <wak@google.com>

test/test_ethernet_interface.cpp

diff --git a/test/test_ethernet_interface.cpp b/test/test_ethernet_interface.cpp
index 497eaa0..ad30c0a 100644
--- a/test/test_ethernet_interface.cpp
+++ b/test/test_ethernet_interface.cpp
@@ -39,15 +39,13 @@
     {
     }
 
-    static constexpr ether_addr mac{0x11, 0x22, 0x33, 0x44, 0x55, 0x66};
-
     static MockEthernetInterface makeInterface(sdbusplus::bus_t& bus,
                                                MockManager& manager)
     {
         mock_clear();
-        mock_addIF("test0", 1, mac);
+        mock_addIF("test0", /*idx=*/1);
         return {bus, "/xyz/openbmc_test/network/test0", config::Parser(),
-                manager, true};
+                manager};
     }
 
     int countIPObjects()
@@ -92,10 +90,28 @@
     }
 };
 
+TEST_F(TestEthernetInterface, Fields)
+{
+    EXPECT_EQ(0, interface.mtu());
+    EXPECT_EQ("", interface.macAddress());
+    EXPECT_FALSE(interface.linkUp());
+
+    constexpr unsigned idx = 2;
+    constexpr ether_addr mac{0x11, 0x22, 0x33, 0x44, 0x55, 0x66};
+    constexpr unsigned mtu = 150;
+
+    mock_addIF("test1", idx, IFF_RUNNING, mac, mtu);
+    MockEthernetInterface intf(bus, "/xyz/openbmc_test/network/test1",
+                               config::Parser(), manager);
+
+    EXPECT_EQ(mtu, intf.mtu());
+    EXPECT_EQ(mac_address::toString(mac), intf.macAddress());
+    EXPECT_TRUE(intf.linkUp());
+}
+
 TEST_F(TestEthernetInterface, NoIPaddress)
 {
     EXPECT_EQ(countIPObjects(), 0);
-    EXPECT_EQ(mac_address::toString(mac), interface.macAddress());
 }
 
 TEST_F(TestEthernetInterface, AddIPAddress)