Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-networkd / 359623e2af84d63b4d37e15a14427f42781146ac
commit359623e2af84d63b4d37e15a14427f42781146ac[log] [tgz]
authorJohnathan Mantey <johnathanx.mantey@intel.com>Tue Jan 26 15:02:54 2021 -0800
committerJohnathan Mantey <johnathanx.mantey@intel.com>Wed Mar 31 20:26:05 2021 +0000
tree2b5e3f9e0f90288b1ec9c20c621762733e536a10
parent983da5568c70a75d0c0c2c2d05ee8e497d6cd4f6 [diff]
Improved IPv6 netmask parsing

The subnet mask parsing in toV6CIDR only worked for very well behaved
subnet strings. This became apparent after the BMC received a DHCP
assigned IPv6 address with an Address Prefix equal to /128. Any
netmask values trailing the final ":" character were ignored. In
addition it assumed all subnet entries would be submitted in shorthand
form.

The changes here handle mask values supplied following the final ":"
character. It also does more sanity checking on the incoming subnet
string.

Tested:
Supplied the function with the following test patterns, and confirmed
the function returns accurate address prefix values.
   ffff:ffff::
   ffff:ffff:ffff::
   ffff:ffff:fc00::
   ffff:0:0:0:0:0:0:0
   ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff
   ffff:ffff:ffff:ffff:ffff:ffff:ffff:fffc
   ffff:0fff::
   ffff:fgff::
   ffff:0:0:6:0:0:0:0
   ::
   :
   abcd:efgh:ijkl:mnop:pqrs:tuvw:xyz:abcd
   ffff:0:0:0:0:0:0

Change-Id: Ib2c73fe07a6a3f1c7a5f0e8f231dfef21badb3af
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
2 files changed
tree: 2b5e3f9e0f90288b1ec9c20c621762733e536a10
  1. docs/
  2. test/
  3. xyz/
  4. .clang-format
  5. .gitignore
  6. argument.cpp
  7. argument.hpp
  8. bootstrap.sh
  9. config_parser.cpp
  10. config_parser.hpp
  11. configure.ac
  12. dhcp_configuration.cpp
  13. dhcp_configuration.hpp
  14. dns_updater.cpp
  15. dns_updater.hpp
  16. ethernet_interface.cpp
  17. ethernet_interface.hpp
  18. ipaddress.cpp
  19. ipaddress.hpp
  20. LICENSE
  21. MAINTAINERS
  22. Makefile.am
  23. ncsi_netlink_main.cpp
  24. ncsi_util.cpp
  25. ncsi_util.hpp
  26. neighbor.cpp
  27. neighbor.hpp
  28. netlink.cpp
  29. netlink.hpp
  30. network_config.cpp
  31. network_config.hpp
  32. network_manager.cpp
  33. network_manager.hpp
  34. network_manager_main.cpp
  35. README.md
  36. routing_table.cpp
  37. routing_table.hpp
  38. rtnetlink_server.cpp
  39. rtnetlink_server.hpp
  40. system_configuration.cpp
  41. system_configuration.hpp
  42. types.hpp
  43. util.cpp
  44. util.hpp
  45. vlan_interface.cpp
  46. vlan_interface.hpp
  47. watch.cpp
  48. watch.hpp
  49. xyz.openbmc_project.Network.conf.in
  50. xyz.openbmc_project.Network.service.in
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.