commit d298f93a824b5c5777c16a865583a9658930b9a9
author William A. Kennington III <wak@google.com> Mon Oct 17 14:31:38 2022 -0700
committer William A. Kennington III <wak@google.com> Sat Nov 05 22:57:17 2022 -0700
tree bb543f306b9aba15132798668e8125bc94b0c237
parent 3e471c5fba065f5fae4d359bdbc9ca3565d913e7

ethernet_interface: Refactor object creation args

We want to be able to pass a bunch of interface properties directly into
interface instead of querying them directly. This will be used later for
rtnetlink enabled interface creation.

Change-Id: I93fbd460a8a54515e84c415f085548cb5528f231
Signed-off-by: William A. Kennington III <wak@google.com>

src/vlan_interface.cpp

diff --git a/src/vlan_interface.cpp b/src/vlan_interface.cpp
index 9f92198..0d7879c 100644
--- a/src/vlan_interface.cpp
+++ b/src/vlan_interface.cpp
@@ -17,19 +17,17 @@
 using namespace phosphor::logging;
 using namespace sdbusplus::xyz::openbmc_project::Common::Error;
 
-VlanInterface::VlanInterface(sdbusplus::bus_t& bus,
-                             stdplus::const_zstring objPath,
-                             const config::Parser& config, bool nicEnabled,
-                             uint32_t vlanID, EthernetInterface& intf,
-                             Manager& parent) :
-    VlanIface(bus, objPath.c_str()),
-    DeleteIface(bus, objPath.c_str()),
-    EthernetInterface(bus, objPath, config, parent, true, nicEnabled),
-    parentInterface(intf)
+VlanInterface::VlanInterface(sdbusplus::bus_t& bus, Manager& manager,
+                             const InterfaceInfo& info,
+                             std::string_view objRoot,
+                             const config::Parser& config, uint16_t vlanID,
+                             EthernetInterface& parent, bool emitSignal,
+                             std::optional<bool> enabled) :
+    EthernetInterface(bus, manager, info, objRoot, config, emitSignal, enabled),
+    DeleteIface(bus, objPath.c_str()), VlanIface(bus, objPath.c_str()),
+    parentInterface(parent)
 {
     id(vlanID);
-    MacAddressIntf::macAddress(parentInterface.macAddress());
-
     emit_object_added();
 }