commit d4ff731e20735f8b1e97a10d51d30a449b695f3f
author William A. Kennington III <wak@google.com> Fri Feb 03 14:19:17 2023 -0800
committer William A. Kennington III <wak@google.com> Mon Jun 26 16:51:20 2023 -0700
tree 58a93bca511ec89118dcd32efee72ca9c7f311f7
parent af77f827b6b33a3c0834565bd168653e4897fe19

ethernet_interface: Refactor gateway setting

Reduce duplication and re-use code.

Change-Id: Id0919c03f439af60f3e4e65860f22e4b61e609a1
Signed-off-by: William A. Kennington III <wak@google.com>

src/ethernet_interface.cpp

diff --git a/src/ethernet_interface.cpp b/src/ethernet_interface.cpp
index a38e7c8..c6cc1b9 100644
--- a/src/ethernet_interface.cpp
+++ b/src/ethernet_interface.cpp
@@ -811,63 +811,44 @@
     manager.get().reloadConfigs();
 }
 
-std::string EthernetInterface::defaultGateway(std::string gateway)
+template <typename Addr>
+static void normalizeGateway(std::string& gw)
 {
+    if (gw.empty())
+    {
+        return;
+    }
     try
     {
-        if (!gateway.empty())
-        {
-            gateway =
-                stdplus::toStr(stdplus::fromStr<stdplus::In4Addr>(gateway));
-        }
+        gw = stdplus::toStr(stdplus::fromStr<Addr>(gw));
     }
     catch (const std::exception& e)
     {
-        lg2::error("Invalid v4 GW {NET_GW}: {ERROR}", "NET_GW", gateway,
-                   "ERROR", e);
+        lg2::error("Invalid GW `{NET_GW}`: {ERROR}", "NET_GW", gw, "ERROR", e);
         elog<InvalidArgument>(Argument::ARGUMENT_NAME("GATEWAY"),
-                              Argument::ARGUMENT_VALUE(gateway.c_str()));
+                              Argument::ARGUMENT_VALUE(gw.c_str()));
     }
+}
 
-    if (EthernetInterfaceIntf::defaultGateway() == gateway)
+std::string EthernetInterface::defaultGateway(std::string gateway)
+{
+    normalizeGateway<stdplus::In4Addr>(gateway);
+    if (gateway != defaultGateway())
     {
-        return gateway;
+        gateway = EthernetInterfaceIntf::defaultGateway(std::move(gateway));
+        manager.get().reloadConfigs();
     }
-    EthernetInterfaceIntf::defaultGateway(gateway);
-
-    writeConfigurationFile();
-    manager.get().reloadConfigs();
-
     return gateway;
 }
 
 std::string EthernetInterface::defaultGateway6(std::string gateway)
 {
-    try
+    normalizeGateway<stdplus::In6Addr>(gateway);
+    if (gateway != defaultGateway6())
     {
-        if (!gateway.empty())
-        {
-            gateway =
-                stdplus::toStr(stdplus::fromStr<stdplus::In6Addr>(gateway));
-        }
+        gateway = EthernetInterfaceIntf::defaultGateway6(std::move(gateway));
+        manager.get().reloadConfigs();
     }
-    catch (const std::exception& e)
-    {
-        lg2::error("Invalid v6 GW {NET_GW}: {ERROR}", "NET_GW", gateway,
-                   "ERROR", e);
-        elog<InvalidArgument>(Argument::ARGUMENT_NAME("GATEWAY"),
-                              Argument::ARGUMENT_VALUE(gateway.c_str()));
-    }
-
-    if (EthernetInterfaceIntf::defaultGateway6() == gateway)
-    {
-        return gateway;
-    }
-    EthernetInterfaceIntf::defaultGateway6(gateway);
-
-    writeConfigurationFile();
-    manager.get().reloadConfigs();
-
     return gateway;
 }