commit dea3ead09a1503daec471d8ed4d24d20bb489451
author Ratan Gupta <ratagupt@in.ibm.com> Wed Aug 02 18:09:25 2017 +0530
committer Ratan Gupta <ratagupt@in.ibm.com> Thu Aug 10 23:58:14 2017 +0530
tree c9174cac5b3771d26c02faf613a2e34eafea5106
parent 70c7e5b5f4fa01308f89266142aa1c4fc8181231

Don't commit the error during getting of DHCP value

When network manager comes up, it parses the file to
get the dhcp value from the config file,if DHCP key is
not there then don't commit the error.

Resolves openbmc/openbmc#2011

Change-Id: Ic86454a3502096cae2edbb9afe917f5567aa84a6
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

config_parser.cpp

diff --git a/config_parser.cpp b/config_parser.cpp
index 51ef55b..9ab601c 100644
--- a/config_parser.cpp
+++ b/config_parser.cpp
@@ -78,17 +78,21 @@
                       const std::string& value)
 {
     KeyValues values;
-    try
+    auto it = sections.find(section);
+    if (it != sections.end())
     {
-        values = getSection(section);
+        values = std::move(it->second);
     }
-    catch (InternalFailure& e)
-    {
-        // don't commit the error.
+    values.insert(std::make_pair(key, value));
 
+    if (it != sections.end())
+    {
+        it->second = std::move(values);
     }
-    values.emplace(key, value);
-    sections.emplace(section, values);
+    else
+    {
+        sections.insert(std::make_pair(section, std::move(values)));
+    }
 }
 
 #if 0

network_manager.cpp

diff --git a/network_manager.cpp b/network_manager.cpp
index e9a62ed..013a61b 100644
--- a/network_manager.cpp
+++ b/network_manager.cpp
@@ -267,7 +267,7 @@
     }
     catch (InternalFailure& e)
     {
-        commit<InternalFailure>();
+       log<level::INFO>("Exception occured during getting of DHCP value");
     }
     return dhcp;
 }