Manage configuration parser file state using RAII
Static code analysis tools flagged the file state handling as a
potential source of resource loss. Change the code to use RAII to
control the file state automatically. This eliminates the need for
manual intervention, and errors that may arise from manual filehandle
management.
Tested:
Placed debug print statements to confirm the stream is still opened,
and the contents parsed. Removed the print statements following
confirmation.
Change-Id: I6f20117b948673a4babc4b702da741145e57a1c6
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
diff --git a/src/config_parser.cpp b/src/config_parser.cpp
index c4af404..1525c5c 100644
--- a/src/config_parser.cpp
+++ b/src/config_parser.cpp
@@ -116,8 +116,7 @@
void Parser::setFile(const fs::path& filePath)
{
this->filePath = filePath;
- std::fstream stream;
- stream.open(filePath.string(), std::fstream::in);
+ std::fstream stream(filePath, std::fstream::in);
if (!stream.is_open())
{
@@ -126,7 +125,6 @@
// clear all the section data.
sections.clear();
parse(stream);
- stream.close();
}
void Parser::parse(std::istream& in)