commit f6f0cf39137e9d02bbbf3eacacf9469bd9b2d181
author William A. Kennington III <wak@google.com> Fri Nov 04 14:28:42 2022 -0700
committer William A. Kennington III <wak@google.com> Wed Nov 09 12:35:29 2022 -0800
tree 3c35d8f1b048e6a91e6164032877dd95c1072cbc
parent 59e5b91d9784274d1d99b4c10e939c38606efacc

ethernet_interface: Normalize IP for gateway

This makes sure gateways that are the same value but different string
representations are ignored.

Change-Id: I48cee3487276edce09ae2ee122d387d6a2a39d68
Signed-off-by: William A. Kennington III <wak@google.com>

src/ethernet_interface.cpp

diff --git a/src/ethernet_interface.cpp b/src/ethernet_interface.cpp
index 49a6eb6..4398926 100644
--- a/src/ethernet_interface.cpp
+++ b/src/ethernet_interface.cpp
@@ -951,48 +951,60 @@
 
 std::string EthernetInterface::defaultGateway(std::string gateway)
 {
-    auto gw = EthernetInterfaceIntf::defaultGateway();
-    if (gw == gateway)
+    try
     {
-        return gw;
+        if (!gateway.empty())
+        {
+            gateway = std::to_string(ToAddr<in_addr>{}(gateway));
+        }
     }
-
-    if (!isValidIP(AF_INET, gateway) && !gateway.empty())
+    catch (const std::exception& e)
     {
-        log<level::ERR>("Not a valid v4 Gateway",
-                        entry("GATEWAY=%s", gateway.c_str()));
+        auto msg = fmt::format("Invalid v4 GW `{}`: {}", gateway, e.what());
+        log<level::ERR>(msg.c_str(), entry("GATEWAY=%s", gateway.c_str()));
         elog<InvalidArgument>(Argument::ARGUMENT_NAME("GATEWAY"),
                               Argument::ARGUMENT_VALUE(gateway.c_str()));
     }
-    gw = EthernetInterfaceIntf::defaultGateway(gateway);
+
+    if (EthernetInterfaceIntf::defaultGateway() == gateway)
+    {
+        return gateway;
+    }
+    EthernetInterfaceIntf::defaultGateway(gateway);
 
     writeConfigurationFile();
     manager.reloadConfigs();
 
-    return gw;
+    return gateway;
 }
 
 std::string EthernetInterface::defaultGateway6(std::string gateway)
 {
-    auto gw = EthernetInterfaceIntf::defaultGateway6();
-    if (gw == gateway)
+    try
     {
-        return gw;
+        if (!gateway.empty())
+        {
+            gateway = std::to_string(ToAddr<in6_addr>{}(gateway));
+        }
     }
-
-    if (!isValidIP(AF_INET6, gateway) && !gateway.empty())
+    catch (const std::exception& e)
     {
-        log<level::ERR>("Not a valid v6 Gateway",
-                        entry("GATEWAY=%s", gateway.c_str()));
+        auto msg = fmt::format("Invalid v6 GW `{}`: {}", gateway, e.what());
+        log<level::ERR>(msg.c_str(), entry("GATEWAY=%s", gateway.c_str()));
         elog<InvalidArgument>(Argument::ARGUMENT_NAME("GATEWAY"),
                               Argument::ARGUMENT_VALUE(gateway.c_str()));
     }
-    gw = EthernetInterfaceIntf::defaultGateway6(gateway);
+
+    if (EthernetInterfaceIntf::defaultGateway6() == gateway)
+    {
+        return gateway;
+    }
+    EthernetInterfaceIntf::defaultGateway6(gateway);
 
     writeConfigurationFile();
     manager.reloadConfigs();
 
-    return gw;
+    return gateway;
 }
 
 EthernetInterface::VlanProperties::VlanProperties(