Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-networkd / f8c78f268153c448ee9a1580933eda953ed99848
commitf8c78f268153c448ee9a1580933eda953ed99848[log] [tgz]
authorWilliam A. Kennington III <wak@google.com>Sat Apr 20 20:32:59 2019 -0700
committerWilliam A. Kennington III <wak@google.com>Tue Jul 23 13:38:02 2019 -0700
treecea420e6695cc10f1f3b81478a43fbad60ab1cc2
parentd7946a71710403aa08b9e53e77b04ab816bc00e5 [diff]
ethernet_interface: Get rid of address gateway usage

This parameter doesn't make any sense the way it is used currently. It
applies a "gateway" route to the routing table for the network of the IP
address that gets assigned to the interface. This ends up with two
routes being configured, one that designates all addresses on the
network be routed locally, and a second that designates those same
addresses be routed through the "gateway". Since the l2 route has
priority, we will never actually use this gateway route. The logic
didn't make sense conceptually anyway.

If you created an ip of 192.168.10.2/24 and gw 192.168.10.1 you would
end up with the routes:
192.168.10.0/24 via 192.168.10.1 dev eth0 proto static
192.168.10.0/24 dev eth0 proto kernel scope link src 192.168.10.100

But the kernel won't actually let you do this an will just ignore the
"gateway" route.

Change-Id: I4fb8b322e45164031599a94e573ff0bbd3cc8eb5
Signed-off-by: William A. Kennington III <wak@google.com>
6 files changed
tree: cea420e6695cc10f1f3b81478a43fbad60ab1cc2
  1. docs/
  2. test/
  3. xyz/
  4. .clang-format
  5. .gitignore
  6. argument.cpp
  7. argument.hpp
  8. bootstrap.sh
  9. config_parser.cpp
  10. config_parser.hpp
  11. configure.ac
  12. dhcp_configuration.cpp
  13. dhcp_configuration.hpp
  14. dns_updater.cpp
  15. dns_updater.hpp
  16. ethernet_interface.cpp
  17. ethernet_interface.hpp
  18. ipaddress.cpp
  19. ipaddress.hpp
  20. LICENSE
  21. logman.py
  22. MAINTAINERS
  23. Makefile.am
  24. ncsi_netlink_main.cpp
  25. ncsi_util.cpp
  26. ncsi_util.hpp
  27. neighbor.cpp
  28. neighbor.hpp
  29. netlink.cpp
  30. netlink.hpp
  31. netman.py
  32. network_config.cpp
  33. network_config.hpp
  34. network_manager.cpp
  35. network_manager.hpp
  36. network_manager_main.cpp
  37. README.md
  38. routing_table.cpp
  39. routing_table.hpp
  40. rtnetlink_server.cpp
  41. rtnetlink_server.hpp
  42. system_configuration.cpp
  43. system_configuration.hpp
  44. types.hpp
  45. userman.py
  46. util.cpp
  47. util.hpp
  48. vlan_interface.cpp
  49. vlan_interface.hpp
  50. watch.cpp
  51. watch.hpp
  52. xyz.openbmc_project.Network.conf.in
  53. xyz.openbmc_project.Network.service.in
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.