commit a77827224ed0847779da98c206450bdd82b21f78
author Joseph.Fu <Joseph.Fu@quantatw.com> Fri Apr 19 12:18:07 2024 +0800
committer Joseph.Fu <Joseph.Fu@quantatw.com> Fri Apr 19 14:59:17 2024 +0800
tree db63e6bbc2dc5cac0bd75a9eb5a2b9c79ec2b091
parent 097562e751d5cd9bf221fa8212cf40a7ea468c3f

nvme_manager: fix check threshold condition

Rel: https://gerrit.openbmc.org/c/openbmc/phosphor-nvme/+/70843
After adding the NVME status flag check, the
TEMPERATURE_SENSOR_FAILURE(0x81) value will be recorded in SEL
when the NVMe status is "Drive Not Ready".

Sensor thresholds are only checked when NVMe status is available.

Tested:
Work fine when running I/O test on QBMC machine.

Change-Id: I7aa155c23d42c455a683771db5fd979ffa5f2df6
Signed-off-by: Joseph.Fu <Joseph.Fu@quantatw.com>

nvme_manager.cpp

diff --git a/nvme_manager.cpp b/nvme_manager.cpp
index 6fa82c2..d0ef7b1 100644
--- a/nvme_manager.cpp
+++ b/nvme_manager.cpp
@@ -625,7 +625,8 @@
         nvmeSSD->setSensorThreshold(config.criticalHigh, config.criticalLow,
                                     config.warningHigh, config.warningLow);
 
-        nvmeSSD->checkSensorThreshold();
+        if (success)
+            nvmeSSD->checkSensorThreshold();
         setLEDsStatus(config, success, nvmeData);
     }
     else
@@ -641,7 +642,8 @@
                 config.criticalHigh, config.criticalLow, config.warningHigh,
                 config.warningLow);
         }
-        iter->second->checkSensorThreshold();
+        if (success)
+            iter->second->checkSensorThreshold();
         setLEDsStatus(config, success, nvmeData);
     }
 }