tree 98526259e3403c90787348acdbb8dec3d549041f
parent d4f5199251f2acbcf007c9bc163fd65d3695655b
author Potin Lai <potin.lai@quantatw.com> 1663758630 +0800
committer Potin Lai <potin.lai@quantatw.com> 1664760580 +0800

nvme_manager: decouple config dependency of PresentPin and PwrGoodPin

Nvme::read() does not allow power good checking if config just have
PwrGoodPin only available, for platform which doesn't have both
PresentPin and PwrGoodPin in config will not able to do power checking.

This patch move out GPIO pin reading to begin of each nvme read, and
set defaule value to PresentPin and PwrGoodPin if the pin is not
defined in the config file, so that the power checking can still be
performed without PresentPin defined.

default value of pins:
- PresentPin: IS_PRESENT (0)
- PwrGoodPin: POWERGD (1)

Tested on Bletchley (only PwrGoodPin defined):

- PwrGoodPin is low
root@bletchley:~# busctl introspect xyz.openbmc_project.nvme.manager \
> /xyz/openbmc_project/sensors/temperature/nvme6 \
> xyz.openbmc_project.Sensor.Value
NAME                             TYPE      SIGNATURE RESULT/VALUE                             FLAGS
.MaxValue                        property  d         127                                      emits-change writable
.MinValue                        property  d         -127                                     emits-change writable
.Unit                            property  s         "xyz.openbmc_project.Sensor.Value.Uni... emits-change writable
.Value                           property  d         -127                                     emits-change writable

- PwrGoodPin is high
root@bletchley:~# busctl introspect xyz.openbmc_project.nvme.manager \
> /xyz/openbmc_project/sensors/temperature/nvme6 \
> xyz.openbmc_project.Sensor.Value
NAME                             TYPE      SIGNATURE RESULT/VALUE                             FLAGS
.MaxValue                        property  d         127                                      emits-change writable
.MinValue                        property  d         -127                                     emits-change writable
.Unit                            property  s         "xyz.openbmc_project.Sensor.Value.Uni... emits-change writable
.Value                           property  d         38                                       emits-change writable

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I00fabf8f387c83bf139539bba9d5ba6aed693778