commit fdffe5c37f0d1feaa90558433f688c3757d2e79a
author Brandon Kim <brandonkim@google.com> Tue Mar 30 15:07:59 2021 -0700
committer Brandon Kim <brandonkim@google.com> Tue Mar 30 22:30:40 2021 +0000
tree 3d1b73794a0ca2d69f7ece323ebf5d924094249b
parent 93455337cbf9b005e761c15bd90bdbe6b13484b8

nvme_manager: Reduce setFaultLEDs D-Bus calls

setFaultLEDs was found to take 1/3 of a read cycle on average. Reduce
the number of time-consuming D-Bus calls by doing a "get" first before
the "set".

Tested: Reduced the average setFaultLEDs operation time by 86%

Bug-Id: openbmc/phosphor-nvme#4
Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I0fe85a3cb286d103ed5d915b32271cc0c3d43bba

nvme_manager.cpp

diff --git a/nvme_manager.cpp b/nvme_manager.cpp
index e73d849..02bc819 100644
--- a/nvme_manager.cpp
+++ b/nvme_manager.cpp
@@ -116,8 +116,12 @@
     // Before toggle LED, check whether is Identify or not.
     if (!getLEDGroupState(locateLedGroupPath))
     {
-        util::SDBusPlus::setProperty(bus, LED_GROUP_BUSNAME, faultLedGroupPath,
-                                     LED_GROUP_IFACE, "Asserted", request);
+        if (getLEDGroupState(faultLedGroupPath) != request)
+        {
+            util::SDBusPlus::setProperty(bus, LED_GROUP_BUSNAME,
+                                         faultLedGroupPath, LED_GROUP_IFACE,
+                                         "Asserted", request);
+        }
     }
 }