commit 787aa8130d57583233bae3011c1417f5607b825b
author Brad Bishop <bradleyb@fuzziesquirrel.com> Sun Jan 28 23:42:03 2018 -0500
committer Brad Bishop <bradleyb@fuzziesquirrel.com> Wed Jan 31 11:18:46 2018 -0500
tree ddbf79b04379a4a4ab756dfa20c415947dc88178
parent 5c5e13eef04098ad3e72b8046b0a36dbe24b942f

server: drop bus check from get_signal_interfaces

No functional changes, but move bus name normalization
from get_signal_interfaces to the call sites.  This improves
signal handler readability.

Changed get_signal_interfaces to filter_signal_interfaces to
more accurately describe what the method does.

Fix-up call sites.

Tested: Manually verified mapper content is the same after service
  discovery.
Change-Id: I0467faa233a960245f8cc8bad14dd66b1b7fead6
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

obmc/mapper/server.py

diff --git a/obmc/mapper/server.py b/obmc/mapper/server.py
index e11f0fe..e1f3af2 100644
--- a/obmc/mapper/server.py
+++ b/obmc/mapper/server.py
@@ -309,7 +309,9 @@
     def interfaces_added_handler(self, path, iprops, **kw):
         path = str(path)
         owner = str(kw['sender'])
-        interfaces = self.get_signal_interfaces(owner, iter(iprops.keys()))
+        if not self.bus_normalize(owner):
+            return
+        interfaces = self.filter_signal_interfaces(iter(iprops.keys()))
         if not interfaces:
             return
 
@@ -329,7 +331,9 @@
     def interfaces_removed_handler(self, path, interfaces, **kw):
         path = str(path)
         owner = str(kw['sender'])
-        interfaces = self.get_signal_interfaces(owner, interfaces)
+        if not self.bus_normalize(owner):
+            return
+        interfaces = self.filter_signal_interfaces(interfaces)
         if not interfaces:
             return
 
@@ -348,7 +352,9 @@
     def properties_changed_handler(self, interface, new, old, **kw):
         owner = str(kw['sender'])
         path = str(kw['path'])
-        interfaces = self.get_signal_interfaces(owner, [interface])
+        if not self.bus_normalize(owner):
+            return
+        interfaces = self.filter_signal_interfaces([interface])
         if not self.is_association(interfaces):
             return
         associations = new.get('associations', None)
@@ -505,12 +511,8 @@
 
         return name
 
-    def get_signal_interfaces(self, owner, interfaces):
-        filtered = []
-        if self.bus_normalize(owner):
-            filtered = [str(x) for x in interfaces if self.interface_match(x)]
-
-        return filtered
+    def filter_signal_interfaces(self, interfaces):
+        return [str(x) for x in interfaces if self.interface_match(x)]
 
     @staticmethod
     def interfaces_get(item, owner, default=[]):