commit 36ab6f6ecf7e1576a418c1b9a15aed502f3aa631
author Patrick Venture <venture@google.com> Mon Aug 03 10:50:26 2020 -0700
committer Patrick Venture <venture@google.com> Mon Aug 03 11:07:06 2020 -0700
tree 09eade06be4b08b7a16fc429f74888b40577977a
parent 6fc301fbc3775730a0e69f215110ec93bd9026f3

move ipmi handler into namespace

Add a namespace for the ipmi code to enable re-use through linking into
other libraries that may have similar object names.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I002b9bf84d5bc6cbe06b9dc8f41cb4532ec50927

ipmi/manualcmds.cpp

diff --git a/ipmi/manualcmds.cpp b/ipmi/manualcmds.cpp
index 3a98c99..ddb70f9 100644
--- a/ipmi/manualcmds.cpp
+++ b/ipmi/manualcmds.cpp
@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+#include "manualcmds.hpp"
+
 #include <ipmid/api.h>
 
 #include <ipmid/iana.hpp>
@@ -26,25 +28,10 @@
 #include <tuple>
 #include <variant>
 
-enum ManualSubCmd
+namespace pid_control
 {
-    GET_CONTROL_STATE = 0,
-    SET_CONTROL_STATE = 1,
-    GET_FAILSAFE_STATE = 2,
-};
-
-struct FanCtrlRequest
+namespace ipmi
 {
-    uint8_t command;
-    uint8_t zone;
-} __attribute__((packed));
-
-struct FanCtrlRequestSet
-{
-    uint8_t command;
-    uint8_t zone;
-    uint8_t value;
-} __attribute__((packed));
 
 static constexpr auto objectPath = "/xyz/openbmc_project/settings/fanctrl/zone";
 static constexpr auto busName = "xyz.openbmc_project.State.FanCtrl";
@@ -235,6 +222,9 @@
     return rc;
 }
 
+} // namespace ipmi
+} // namespace pid_control
+
 void setupGlobalOemFanControl() __attribute__((constructor));
 
 void setupGlobalOemFanControl()
@@ -246,5 +236,5 @@
             oem::obmcOemNumber, oem::Cmd::fanManualCmd);
 
     router->registerHandler(oem::obmcOemNumber, oem::Cmd::fanManualCmd,
-                            manualModeControl);
+                            pid_control::ipmi::manualModeControl);
 }