tree af01104074ee6762062334ddaa3fb35c13b510b0
parent 79cde00af75a15e60fa91a367b49421baf8530cf
author Zev Weiss <zev@bewilderbeest.net> 1678157916 -0800
committer Zev Weiss <zev@bewilderbeest.net> 1680115783 -0700

Allow indefinite retries in tryRestartControlLoops()

On some platforms, when the BMC first starts up the sensors used in
swampd's PID loops may not yet exist, and may not start existing until
the host is first powered on.  Since that may not happen for an
arbitrarily long time, swampd can end up crashing after exhausting its
artificially-limited retry budget in tryRestartControlLoops(), at which
point it gets restarted by systemd and the loop continues.  Each time it
crashes we generate a warning in the Redfish event log though, which
isn't ideal since nothing truly erroneous has actually happened (aside
from the daemon somewhat spuriously dying).

With this change we instead allow tryRestartControlLoops() to retry
indefinitely without crashing the process, so that it can simply wait
until the sensors it's configured to use eventually appear.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I13f591fded2563731cb5a8c3a67283b57f99f6bf