commit 8f1791448e2da0eda0dae5785becf977309106d5
author Patrick Venture <venture@google.com> Mon Sep 10 09:24:12 2018 -0700
committer Patrick Venture <venture@google.com> Mon Sep 10 22:34:16 2018 +0000
tree 2349111658c6f1035f11f95062aed91e3bd2839e
parent 54c2e5e2dfdcd069c3688ad5d67ee016cddf4183

ipmi: add back call to is_method_error

Before reading the message, check if there's an error.  The bus call
will fail dramatically but differently than the message.

Change-Id: I3ab54cc4a4590e0cf5f3eb15dcbf045a7b8bd075
Signed-off-by: Patrick Venture <venture@google.com>

ipmi/manualcmds.cpp

diff --git a/ipmi/manualcmds.cpp b/ipmi/manualcmds.cpp
index 798deab..a82dfa6 100644
--- a/ipmi/manualcmds.cpp
+++ b/ipmi/manualcmds.cpp
@@ -86,9 +86,15 @@
 
     try
     {
-        auto valueResponseMsg = propertyReadBus.call(pimMsg);
-
         PropertyMap propMap;
+
+        /* a method could error but the call not error. */
+        auto valueResponseMsg = propertyReadBus.call(pimMsg);
+        if (valueResponseMsg.is_method_error())
+        {
+            return IPMI_CC_INVALID;
+        }
+
         valueResponseMsg.read(propMap);
 
         *value = sdbusplus::message::variant_ns::get<bool>(propMap[property]);