commit c399f6fbdbd17c35a8920ee9cfff08b3d67bc836
author Patrick Venture <venture@google.com> Tue Oct 30 19:24:47 2018 -0700
committer Patrick Venture <venture@google.com> Tue Oct 30 19:27:07 2018 -0700
tree c7d83c5241d5d999d7cc9ab257a358ff47ed481a
parent 2d8e78510d8c1da8ea14cbccd3217275619eadd0

zone: use const reference consistently

In this case, the string is copied and placed into the vector's pointer
list, so it's not necessary to be passed by const reference.  However,
for consistency it's a harmless change.

Change-Id: I5c02e98b4789e18bc9a6756bdd8c5184ad12a232
Signed-off-by: Patrick Venture <venture@google.com>

pid/zone.cpp

diff --git a/pid/zone.cpp b/pid/zone.cpp
index b1da7ec..81425c3 100644
--- a/pid/zone.cpp
+++ b/pid/zone.cpp
@@ -96,12 +96,12 @@
     return _cachedValuesByName.at(name);
 }
 
-void PIDZone::addFanInput(std::string fan)
+void PIDZone::addFanInput(const std::string& fan)
 {
     _fanInputs.push_back(fan);
 }
 
-void PIDZone::addThermalInput(std::string therm)
+void PIDZone::addThermalInput(const std::string& therm)
 {
     _thermalInputs.push_back(therm);
 }

pid/zone.hpp

diff --git a/pid/zone.hpp b/pid/zone.hpp
index 6db7b7e..37fcc77 100644
--- a/pid/zone.hpp
+++ b/pid/zone.hpp
@@ -80,8 +80,8 @@
     void addFanPID(std::unique_ptr<Controller> pid);
     void addThermalPID(std::unique_ptr<Controller> pid);
     double getCachedValue(const std::string& name) override;
-    void addFanInput(std::string fan);
-    void addThermalInput(std::string therm);
+    void addFanInput(const std::string& fan);
+    void addThermalInput(const std::string& therm);
 
 #ifdef __TUNING_LOGGING__
     void initializeLog(void);