Allow derivativeCoeff and DCoefficient optional
To avoid breaking existing configurations in the field, treat the
new "derivativeCoeff" parameter as optional, not mandatory.
This affects both the old JSON parser, and the new D-Bus
entity-manager parser (it's called "DCoefficient" there).
Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Ifcaf47d66e009b48e41b510a2ef1686b8860ad35
diff --git a/test/pid_json_unittest.cpp b/test/pid_json_unittest.cpp
index b6963cd..eb9ca58 100644
--- a/test/pid_json_unittest.cpp
+++ b/test/pid_json_unittest.cpp
@@ -31,6 +31,7 @@
TEST(ZoneFromJson, oneZoneOnePid)
{
// Parse a valid configuration with one zone and one PID.
+ // Intentionally omits "derivativeCoeff" to test that it is optional.
std::map<int64_t, conf::PIDConf> pidConfig;
std::map<int64_t, conf::ZoneConfig> zoneConfig;
@@ -50,7 +51,6 @@
"samplePeriod": 0.1,
"proportionalCoeff": 0.0,
"integralCoeff": 0.0,
- "derivativeCoeff": 0.0,
"feedFwdOffsetCoeff": 0.0,
"feedFwdGainCoeff": 0.010,
"integralLimit_min": 0.0,