commit d2768c5703832aa06eaca57020c212dc8161c787
author Ed Tanous <etanous@nvidia.com> Thu Jun 26 11:42:57 2025 -0700
committer Ed Tanous <ed@tanous.net> Fri Jun 27 13:08:35 2025 -0700
tree c5ba3c25f5b6be8af3ceffe689833220bc43ecb9
parent 897f31c77db9178ecfe8130d43a24c6dac73ff3a

Implement clang-tidy fixes

clang-tidy allows the CI robot to check many things via static analysis.

All changes here were made by the clang-tidy robot, and include a number
of modernization fixes.  updating the tidy file will be done at a later
date.

Signed-off-by: Ed Tanous <etanous@nvidia.com>
Change-Id: I98cc4d600a3c589675507958f6d2350b2141216b

dbus/dbusconfiguration.cpp

diff --git a/dbus/dbusconfiguration.cpp b/dbus/dbusconfiguration.cpp
index 7e34b55..8b18b4f 100644
--- a/dbus/dbusconfiguration.cpp
+++ b/dbus/dbusconfiguration.cpp
@@ -73,7 +73,7 @@
 
 inline std::string getSensorNameFromPath(const std::string& dbusPath)
 {
-    return dbusPath.substr(dbusPath.find_last_of("/") + 1);
+    return dbusPath.substr(dbusPath.find_last_of('/') + 1);
 }
 
 inline std::string sensorNameToDbusName(const std::string& sensorName)

dbus/dbushelper.hpp

diff --git a/dbus/dbushelper.hpp b/dbus/dbushelper.hpp
index 780f708..357d80e 100644
--- a/dbus/dbushelper.hpp
+++ b/dbus/dbushelper.hpp
@@ -25,7 +25,7 @@
 
     explicit DbusHelper(sdbusplus::bus_t& bus) : _bus(bus) {}
     DbusHelper() = delete;
-    ~DbusHelper() = default;
+    ~DbusHelper() override = default;
 
     DbusHelper(const DbusHelper&) = delete;
     DbusHelper& operator=(const DbusHelper&) = delete;

dbus/dbusutil.cpp

diff --git a/dbus/dbusutil.cpp b/dbus/dbusutil.cpp
index 18d8f36..2a0c923 100644
--- a/dbus/dbusutil.cpp
+++ b/dbus/dbusutil.cpp
@@ -84,7 +84,7 @@
     {
         if (std::regex_search(sensor.first, match, reg))
         {
-            matches.push_back(sensor);
+            matches.emplace_back(sensor);
         }
     }
     return matches.size() > 0;