commit d2768c5703832aa06eaca57020c212dc8161c787
author Ed Tanous <etanous@nvidia.com> Thu Jun 26 11:42:57 2025 -0700
committer Ed Tanous <ed@tanous.net> Fri Jun 27 13:08:35 2025 -0700
tree c5ba3c25f5b6be8af3ceffe689833220bc43ecb9
parent 897f31c77db9178ecfe8130d43a24c6dac73ff3a

Implement clang-tidy fixes

clang-tidy allows the CI robot to check many things via static analysis.

All changes here were made by the clang-tidy robot, and include a number
of modernization fixes.  updating the tidy file will be done at a later
date.

Signed-off-by: Ed Tanous <etanous@nvidia.com>
Change-Id: I98cc4d600a3c589675507958f6d2350b2141216b

failsafeloggers/failsafe_logger.cpp

diff --git a/failsafeloggers/failsafe_logger.cpp b/failsafeloggers/failsafe_logger.cpp
index 91416e0..f1fcb14 100644
--- a/failsafeloggers/failsafe_logger.cpp
+++ b/failsafeloggers/failsafe_logger.cpp
@@ -8,7 +8,7 @@
 
 void FailsafeLogger::outputFailsafeLog(
     const int64_t zoneId, const bool newFailsafeState,
-    const std::string location, const std::string reason)
+    const std::string& location, const std::string& reason)
 {
     // Remove outdated log entries.
     const auto now = std::chrono::high_resolution_clock::now();

failsafeloggers/failsafe_logger.hpp

diff --git a/failsafeloggers/failsafe_logger.hpp b/failsafeloggers/failsafe_logger.hpp
index 0e13919..b53e9f2 100644
--- a/failsafeloggers/failsafe_logger.hpp
+++ b/failsafeloggers/failsafe_logger.hpp
@@ -39,8 +39,8 @@
     /** Attempt to output an entering/leaving-failsafe-mode log.
      */
     void outputFailsafeLog(int64_t zoneId, bool newFailsafeState,
-                           const std::string location,
-                           const std::string reason);
+                           const std::string& location,
+                           const std::string& reason);
 
   private:
     // The maximum number of log entries to be output within 1 second.

failsafeloggers/failsafe_logger_utility.hpp

diff --git a/failsafeloggers/failsafe_logger_utility.hpp b/failsafeloggers/failsafe_logger_utility.hpp
index 05ed3ea..465fcdb 100644
--- a/failsafeloggers/failsafe_logger_utility.hpp
+++ b/failsafeloggers/failsafe_logger_utility.hpp
@@ -24,8 +24,8 @@
  * logs for its corresponding zones.
  */
 inline void outputFailsafeLogWithSensor(
-    const std::string sensorName, const bool newFailsafeState,
-    const std::string location, const std::string reason)
+    const std::string& sensorName, const bool newFailsafeState,
+    const std::string& location, const std::string& reason)
 {
     for (const int64_t zoneId : sensorNameToZoneId[sensorName])
     {
@@ -42,7 +42,7 @@
  */
 inline void outputFailsafeLogWithZone(
     const int64_t zoneId, const bool newFailsafeState,
-    const std::string location, const std::string reason)
+    const std::string& location, const std::string& reason)
 {
     if (zoneIdToFailsafeLogger.count(zoneId))
     {