Implement clang-tidy fixes
clang-tidy allows the CI robot to check many things via static analysis.
All changes here were made by the clang-tidy robot, and include a number
of modernization fixes. updating the tidy file will be done at a later
date.
Signed-off-by: Ed Tanous <etanous@nvidia.com>
Change-Id: I98cc4d600a3c589675507958f6d2350b2141216b
diff --git a/pid/fancontroller.hpp b/pid/fancontroller.hpp
index 700f651..cfcaf99 100644
--- a/pid/fancontroller.hpp
+++ b/pid/fancontroller.hpp
@@ -25,10 +25,10 @@
FanController(const std::string& id, const std::vector<std::string>& inputs,
ZoneInterface* owner) :
- PIDController(id, owner), _inputs(inputs),
- _direction(FanSpeedDirection::NEUTRAL)
+ PIDController(id, owner), _inputs(inputs)
{}
- ~FanController();
+
+ ~FanController() override;
double inputProc(void) override;
double setptProc(void) override;
void outputProc(double value) override;
@@ -45,7 +45,7 @@
private:
std::vector<std::string> _inputs;
- FanSpeedDirection _direction;
+ FanSpeedDirection _direction = FanSpeedDirection::NEUTRAL;
// Cosmetic only, to reduce frequency of repetitive messages
bool failsafeTransition = true;