commit d3e71ced5d5e411db8a678c3b581f87973c73307
author Alexander Hansen <alexander.hansen@9elements.com> Wed Nov 12 16:20:53 2025 +0100
committer Alexander Hansen <alexander.hansen@9elements.com> Wed Nov 12 16:26:29 2025 +0100
tree 03d6deb96b8eec7967e39e4cd7ff5f7406004187
parent d76654375d061eeb00c7b7749dddad155926c386

Sensor.Threshold.*: use PDI constants

Use PDI constants instead of local definitions.

Tested: Unit Tests Pass

Change-Id: I2472307d1f4f2d65ad99440243444057c652b85a
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

dbus/dbusconfiguration.cpp

diff --git a/dbus/dbusconfiguration.cpp b/dbus/dbusconfiguration.cpp
index aa23a96..2814b65 100644
--- a/dbus/dbusconfiguration.cpp
+++ b/dbus/dbusconfiguration.cpp
@@ -35,6 +35,8 @@
 #include <xyz/openbmc_project/Control/FanPwm/client.hpp>
 #include <xyz/openbmc_project/Control/ThermalMode/common.hpp>
 #include <xyz/openbmc_project/ObjectMapper/common.hpp>
+#include <xyz/openbmc_project/Sensor/Threshold/Critical/common.hpp>
+#include <xyz/openbmc_project/Sensor/Threshold/Warning/common.hpp>
 #include <xyz/openbmc_project/Sensor/Value/client.hpp>
 
 #include <algorithm>
@@ -59,6 +61,10 @@
 using ControlFanPwm = sdbusplus::common::xyz::openbmc_project::control::FanPwm;
 using ControlThermalMode =
     sdbusplus::common::xyz::openbmc_project::control::ThermalMode;
+using SensorThresholdWarning =
+    sdbusplus::common::xyz::openbmc_project::sensor::threshold::Warning;
+using SensorThresholdCritical =
+    sdbusplus::common::xyz::openbmc_project::sensor::threshold::Critical;
 
 namespace pid_control
 {
@@ -77,10 +83,6 @@
 
 namespace thresholds
 {
-constexpr const char* warningInterface =
-    "xyz.openbmc_project.Sensor.Threshold.Warning";
-constexpr const char* criticalInterface =
-    "xyz.openbmc_project.Sensor.Threshold.Critical";
 const std::array<const char*, 4> types = {"CriticalLow", "CriticalHigh",
                                           "WarningLow", "WarningHigh"};
 
@@ -351,14 +353,16 @@
     if (thresholdProperty != nullptr)
     {
         std::string interface;
-        if (*thresholdProperty == "WarningHigh" ||
-            *thresholdProperty == "WarningLow")
+        if (*thresholdProperty ==
+                SensorThresholdWarning::property_names::warning_high ||
+            *thresholdProperty ==
+                SensorThresholdWarning::property_names::warning_low)
         {
-            interface = thresholds::warningInterface;
+            interface = SensorThresholdWarning::interface;
         }
         else
         {
-            interface = thresholds::criticalInterface;
+            interface = SensorThresholdCritical::interface;
         }
 
         // Although this checks only the first vector element for the