commit dae4a3abb5c2edad1de086d9dac8da576da16d90
author Alexander Hansen <alexander.hansen@9elements.com> Tue Nov 11 17:12:01 2025 +0100
committer Alexander Hansen <alexander.hansen@9elements.com> Tue Nov 11 17:23:22 2025 +0100
tree 5d582238c34e8385c6cba3413b30bab30f0fe664
parent 35ae0bb540c16b098b441394c1f7286a85e6e164

Sensor.Value: use PDI constants

Use PDI constants instead of local definitions.

Tested: Unit Tests Pass

Change-Id: I6b513155afa760da52dc7421eedcfe78ff3a816d
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

dbus/dbushelper.cpp

diff --git a/dbus/dbushelper.cpp b/dbus/dbushelper.cpp
index 7e604b8..4a692cb 100644
--- a/dbus/dbushelper.cpp
+++ b/dbus/dbushelper.cpp
@@ -12,6 +12,7 @@
 #include <sdbusplus/bus.hpp>
 #include <sdbusplus/exception.hpp>
 #include <xyz/openbmc_project/ObjectMapper/common.hpp>
+#include <xyz/openbmc_project/Sensor/Value/client.hpp>
 
 #include <cstdint>
 #include <map>
@@ -21,6 +22,7 @@
 #include <vector>
 
 using ObjectMapper = sdbusplus::common::xyz::openbmc_project::ObjectMapper;
+using SensorValue = sdbusplus::common::xyz::openbmc_project::sensor::Value;
 
 namespace pid_control
 {
@@ -73,7 +75,7 @@
     auto pimMsg = _bus.new_method_call(service.c_str(), path.c_str(),
                                        propertiesintf, "GetAll");
 
-    pimMsg.append(sensorintf);
+    pimMsg.append(SensorValue::interface);
 
     PropertyMap propMap;
 
@@ -97,14 +99,16 @@
     // "Scale" x -3
 
     // If no error was set, the values should all be there.
-    auto findUnit = propMap.find("Unit");
+    auto findUnit = propMap.find(SensorValue::property_names::unit);
     if (findUnit != propMap.end())
     {
         prop->unit = std::get<std::string>(findUnit->second);
     }
+    // TODO: in PDI there is no such 'Scale' property on the Sensor.Value
+    // interface
     auto findScale = propMap.find("Scale");
-    auto findMax = propMap.find("MaxValue");
-    auto findMin = propMap.find("MinValue");
+    auto findMax = propMap.find(SensorValue::property_names::max_value);
+    auto findMin = propMap.find(SensorValue::property_names::min_value);
 
     prop->min = 0;
     prop->max = 0;
@@ -122,7 +126,8 @@
         prop->min = std::visit(VariantToDoubleVisitor(), findMin->second);
     }
 
-    prop->value = std::visit(VariantToDoubleVisitor(), propMap["Value"]);
+    prop->value = std::visit(VariantToDoubleVisitor(),
+                             propMap[SensorValue::property_names::value]);
 
     bool available = true;
     try