commit df766f251f25e32ccbfe1e3ea429f118478422bd
author Patrick Venture <venture@google.com> Sat Oct 13 09:30:58 2018 -0700
committer Patrick Venture <venture@google.com> Sat Oct 13 09:35:40 2018 -0700
tree 9c8939a4bb99a87e20903e9d175cc9393b088f02
parent 45153926a6aa838f4ad83db681f97f8af17fc5f5

cleanup: reduce scope of variables

Various things caught by cppcheck that are non-critical.

Change-Id: I495453c84bc15788b85036a163ee36b0ac601fa1
Signed-off-by: Patrick Venture <venture@google.com>

pid/zone.cpp

diff --git a/pid/zone.cpp b/pid/zone.cpp
index 92a332e..d5e2646 100644
--- a/pid/zone.cpp
+++ b/pid/zone.cpp
@@ -132,13 +132,15 @@
     static constexpr auto setpointpath = "/etc/thermal.d/set-point";
     try
     {
-        int value;
         std::ifstream ifs;
         ifs.open(setpointpath);
         if (ifs.good())
         {
+            int value;
             ifs >> value;
-            max = value; // expecting RPM set-point, not pwm%
+
+            /* expecting RPM set-point, not pwm% */
+            max = static_cast<float>(value);
         }
     }
     catch (const std::exception& e)