commit f8b6e55147148c3cfb42327ff267197a460b411c
author Ed Tanous <etanous@nvidia.com> Fri Jun 27 13:27:50 2025 -0700
committer Ed Tanous <ed@tanous.net> Mon Jun 30 17:48:01 2025 +0000
tree 243b84308e4bb196e8f87ce6df9fbac6a58e122a
parent 7d6e225b8c3f04a390d8cd8bbb911e5838d493d1

Fix includes

Run misc-include-cleaner on the codebase and fix all the includes.

misc-include-cleaner gets some things wrong, so had edit those back to
previous.  It doesn't seem to like nlohmann or zone.hpp very much.

At some point in the future we could fix these, and get these enforced
at CI time.

Change-Id: Ie087e03dd26570db09e44e5b3f0641fb77668711
Signed-off-by: Ed Tanous <etanous@nvidia.com>

ipmi/dbus_mode.cpp

diff --git a/ipmi/dbus_mode.cpp b/ipmi/dbus_mode.cpp
index c72a00a..85427a8 100644
--- a/ipmi/dbus_mode.cpp
+++ b/ipmi/dbus_mode.cpp
@@ -19,9 +19,11 @@
 #include <ipmid/api.h>
 
 #include <sdbusplus/bus.hpp>
+#include <sdbusplus/exception.hpp>
 #include <sdbusplus/message.hpp>
 
 #include <cstdint>
+#include <map>
 #include <string>
 #include <variant>
 

ipmi/main_ipmi.cpp

diff --git a/ipmi/main_ipmi.cpp b/ipmi/main_ipmi.cpp
index 2dd6a75..d867dd5 100644
--- a/ipmi/main_ipmi.cpp
+++ b/ipmi/main_ipmi.cpp
@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-#include "control.hpp"
 #include "dbus_mode.hpp"
 #include "manualcmds.hpp"
 

ipmi/manualcmds.cpp

diff --git a/ipmi/manualcmds.cpp b/ipmi/manualcmds.cpp
index d9c9c49..69817b2 100644
--- a/ipmi/manualcmds.cpp
+++ b/ipmi/manualcmds.cpp
@@ -17,19 +17,14 @@
 #include "manualcmds.hpp"
 
 #include "control.hpp"
-#include "dbus_mode.hpp"
 #include "manual_messages.hpp"
 
 #include <ipmid/api.h>
 
-#include <sdbusplus/bus.hpp>
-#include <sdbusplus/message.hpp>
-
-#include <map>
+#include <cstddef>
+#include <cstdint>
 #include <memory>
 #include <string>
-#include <tuple>
-#include <variant>
 
 namespace pid_control
 {

ipmi/manualcmds.hpp

diff --git a/ipmi/manualcmds.hpp b/ipmi/manualcmds.hpp
index 057ffc9..3f4d6d4 100644
--- a/ipmi/manualcmds.hpp
+++ b/ipmi/manualcmds.hpp
@@ -4,8 +4,10 @@
 
 #include <ipmid/api.h>
 
+#include <cstddef>
 #include <cstdint>
 #include <memory>
+#include <utility>
 
 namespace pid_control
 {