commit ffc5ca7fb2779445782480ec720911e68713ac33
author Patrick Venture <venture@google.com> Tue Oct 30 22:34:53 2018 -0700
committer Patrick Venture <venture@google.com> Tue Oct 30 22:36:50 2018 -0700
tree e15f34082aab62c32e883c8a0d86b406f15f5d4f
parent c179d406a56b326dacb196c90f0de3f1125afc70

manager: use pass by reference by default

Even thought the string must be copied, pass by reference.

Change-Id: I48113237f342279e3f266bbda6e54d770afd2afc
Signed-off-by: Patrick Venture <venture@google.com>

sensors/manager.cpp

diff --git a/sensors/manager.cpp b/sensors/manager.cpp
index 78b7e64..84f7435 100644
--- a/sensors/manager.cpp
+++ b/sensors/manager.cpp
@@ -19,7 +19,7 @@
 
 #include "conf.hpp"
 
-void SensorManager::addSensor(std::string type, std::string name,
+void SensorManager::addSensor(const std::string& type, const std::string& name,
                               std::unique_ptr<Sensor> sensor)
 {
     _sensorMap[name] = std::move(sensor);

sensors/manager.hpp

diff --git a/sensors/manager.hpp b/sensors/manager.hpp
index 97e20cf..f4f3651 100644
--- a/sensors/manager.hpp
+++ b/sensors/manager.hpp
@@ -37,7 +37,7 @@
     /*
      * Add a Sensor to the Manager.
      */
-    void addSensor(std::string type, std::string name,
+    void addSensor(const std::string& type, const std::string& name,
                    std::unique_ptr<Sensor> sensor);
 
     // TODO(venture): Should implement read/write by name.