commit c1819379d12c286c8f17175f76e970d14c73d480
author Bonnie Lo <Bonnie_Lo@wiwynn.com> Thu Oct 27 17:14:55 2022 +0800
committer Bonnie Lo <Bonnie_Lo@wiwynn.com> Tue Nov 01 09:00:46 2022 +0800
tree 3e91a9ac26f6a4f8081dc0acfedabb43a2318468
parent a27519e987a8341585e50913930862825c48cd26

Max post code file size per cycle setting

Let user could set POST code file size per cycle

The default size is 512 counts

Reason:
BMC may crash caused by nonstop saving POST code when BIOS has
some unusual behavior like PXE loop
Thus, BMC should set a limit size to prevent this risk

Test Case:
Manually send POST code to check the POST code file rotation

Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>
Change-Id: Ic7fbafe532a79123e6ae880a8a3506f9c397d933

meson.build

diff --git a/meson.build b/meson.build
index 3209a1f..e7cf00d 100644
--- a/meson.build
+++ b/meson.build
@@ -16,6 +16,7 @@
 conf_data.set_quoted('DBUS_OBJECT_NAME', '/xyz/openbmc_project/State/Boot/PostCode0')
 conf_data.set_quoted('DBUS_INTF_NAME','xyz.openbmc_project.State.Boot.PostCode')
 conf_data.set('MAX_BOOT_CYCLE_COUNT',get_option('max-boot-cycle-count'))
+conf_data.set('MAX_POST_CODE_SIZE_PER_CYCLE',get_option('max-post-code-size-per-cycle'))
 
 if get_option('bios-post-code-log').enabled()
   add_project_arguments('-DENABLE_BIOS_POST_CODE_LOG',language: 'cpp')

meson_options.txt

diff --git a/meson_options.txt b/meson_options.txt
index c3d63fd..d877b97 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,2 +1,3 @@
 option('max-boot-cycle-count', type:'integer', min:1, max: 100, description: 'Maximum boot cycles for which the post codes should be persisted', value:100)
 option('bios-post-code-log', type:'feature',description:'bios post code log',value:'disabled')
+option('max-post-code-size-per-cycle', type:'integer', min:64, max: 1024, description: 'Maximum post code file size per cycle', value:512)

src/post_code.cpp

diff --git a/src/post_code.cpp b/src/post_code.cpp
index b1ffab8..82dba46 100644
--- a/src/post_code.cpp
+++ b/src/post_code.cpp
@@ -93,6 +93,10 @@
     }
 
     postCodes.insert(std::make_pair(tsUS, code));
+    if (postCodes.size() > MAX_POST_CODE_SIZE_PER_CYCLE)
+    {
+        postCodes.erase(postCodes.begin());
+    }
     serialize(fs::path(strPostCodeListPath));
 
 #ifdef ENABLE_BIOS_POST_CODE_LOG