Move D-Bus finder class constructors
Three classes in this repository search for D-Bus interfaces and call
a callback when interfaces are found:
- DBusInterfacesFinder
- CompatibleSystemTypesFinder
- DeviceFinder
The constructors of these three classes may immediately call the
callback. For this reason, these constructors should not be used in the
initialization list of constructors in other classes. Otherwise the
callback may be called before the other class is fully initialized,
leading to unpredictable behavior.
Move usage of these three constructors from initialization lists to
constructor bodies.
Tested:
+ CompatibleSystemTypesFinder
+ Test where compatible system types interface already exists on D-Bus
+ Verify callback is called immediately
+ Test where compatible system types interface does not already exist
on D-Bus
+ Verify callback is called later when interface is added
+ Verify callback is passed the correct data
+ DeviceFinder
+ Test where device interface already exists on D-Bus
+ Verify callback is called immediately
+ Test where device interface does not already exist on D-Bus
+ Verify callback is called later when interface is added
+ Verify callback is passed the correct data
Change-Id: If089f4720012d837b464137b5d3c8fba5dbdc335
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
diff --git a/dbus_interfaces_finder.hpp b/dbus_interfaces_finder.hpp
index 35a80c7..db89e26 100644
--- a/dbus_interfaces_finder.hpp
+++ b/dbus_interfaces_finder.hpp
@@ -73,6 +73,12 @@
/**
* Constructor.
*
+ * Note: The callback function may be called immediately by this
+ * constructor. For this reason, do not use this constructor in the
+ * initialization list of constructors in other classes. Otherwise the
+ * callback may be called before the other class is fully initialized,
+ * leading to unpredictable behavior.
+ *
* @param bus D-Bus bus object
* @param service D-Bus service that owns the object paths implementing
* the specified interfaces