regulators: Convert to new SensorType enumeration
There are several types of voltage regulator sensors, such as vout,
iout, and temperature.
The sensor types were previously defined by the enumeration
pmbus_utils::SensorValueType. This enumeration should not have been
placed in the pmbus_utils namespace because it is not specific to PMBus.
A new enumeration with the simpler name SensorType was created in
sensors.hpp in a previous commit.
Remove the old enumeration from pmbus_utils. Convert affected files to
use the new enumeration.
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I4136b392b104edd3eee41ec29c779ad084c7c4de
diff --git a/phosphor-regulators/src/actions/pmbus_read_sensor_action.cpp b/phosphor-regulators/src/actions/pmbus_read_sensor_action.cpp
index fd58ae2..7ad0cad 100644
--- a/phosphor-regulators/src/actions/pmbus_read_sensor_action.cpp
+++ b/phosphor-regulators/src/actions/pmbus_read_sensor_action.cpp
@@ -74,7 +74,7 @@
{
std::ostringstream ss;
ss << "pmbus_read_sensor: { ";
- ss << "type: " << pmbus_utils::toString(type) << ", " << std::hex
+ ss << "type: " << sensors::toString(type) << ", " << std::hex
<< std::uppercase;
ss << "command: 0x" << static_cast<uint16_t>(command) << ", " << std::dec
<< std::nouppercase;
diff --git a/phosphor-regulators/src/actions/pmbus_read_sensor_action.hpp b/phosphor-regulators/src/actions/pmbus_read_sensor_action.hpp
index 620a814..36df590 100644
--- a/phosphor-regulators/src/actions/pmbus_read_sensor_action.hpp
+++ b/phosphor-regulators/src/actions/pmbus_read_sensor_action.hpp
@@ -19,6 +19,7 @@
#include "i2c_action.hpp"
#include "i2c_interface.hpp"
#include "pmbus_utils.hpp"
+#include "sensors.hpp"
#include <cstdint>
#include <optional>
@@ -57,7 +58,7 @@
/**
* Constructor.
*
- * @param type Sensor value type.
+ * @param type Sensor type.
* @param command PMBus command code.
* @param format Data format of the sensor value returned by the device.
* @param exponent Exponent value for linear_16 data format.
@@ -65,8 +66,7 @@
* exponent value will be read from VOUT_MODE.
* Should not be specified if the data format is linear_11.
*/
- explicit PMBusReadSensorAction(pmbus_utils::SensorValueType type,
- uint8_t command,
+ explicit PMBusReadSensorAction(SensorType type, uint8_t command,
pmbus_utils::SensorDataFormat format,
std::optional<int8_t> exponent) :
type{type},
@@ -79,7 +79,7 @@
*
* Reads one sensor using the I2C interface.
*
- * The sensor value type is specified in the constructor.
+ * The sensor type is specified in the constructor.
*
* The PMBus command code is specified in the constructor.
* It is the register to read on the device.
@@ -132,11 +132,11 @@
}
/**
- * Returns the sensor value type.
+ * Returns the sensor type.
*
- * @return sensor value type.
+ * @return sensor type.
*/
- pmbus_utils::SensorValueType getType() const
+ SensorType getType() const
{
return type;
}
@@ -167,9 +167,9 @@
i2c::I2CInterface& interface);
/**
- * Sensor value type.
+ * Sensor type.
*/
- const pmbus_utils::SensorValueType type{};
+ const SensorType type{};
/**
* PMBus command code.