commit 36d8b7d59f43d9dee543899d0ea2c9c869c77c8d
author Shawn McCarney <shawnmm@us.ibm.com> Mon Oct 28 14:06:12 2019 -0500
committer Shawn McCarney <shawnmm@us.ibm.com> Wed Oct 30 16:05:04 2019 -0500
tree e57b416ae33374a88d2bc98e98af8a7982059287
parent 4afb285e5ab2d708f78949a84608306b8f2568ee

Add explicit keyword to regulator constructors

Add the 'explicit' keyword to regulator constructors.  This prevents
automatic, unintended type promotions from occurring.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Ice9983093114192c33d083b58cf85247d29792a8

phosphor-regulators/src/device.hpp

diff --git a/phosphor-regulators/src/device.hpp b/phosphor-regulators/src/device.hpp
index fd5d844..5f443b5 100644
--- a/phosphor-regulators/src/device.hpp
+++ b/phosphor-regulators/src/device.hpp
@@ -45,7 +45,7 @@
      *
      * @param id unique device ID
      */
-    Device(const std::string& id) : id{id}
+    explicit Device(const std::string& id) : id{id}
     {
     }
 

phosphor-regulators/src/rail.hpp

diff --git a/phosphor-regulators/src/rail.hpp b/phosphor-regulators/src/rail.hpp
index f825863..d5d3b13 100644
--- a/phosphor-regulators/src/rail.hpp
+++ b/phosphor-regulators/src/rail.hpp
@@ -48,7 +48,7 @@
      *
      * @param id unique rail ID
      */
-    Rail(const std::string& id) : id{id}
+    explicit Rail(const std::string& id) : id{id}
     {
     }
 

phosphor-regulators/src/rule.hpp

diff --git a/phosphor-regulators/src/rule.hpp b/phosphor-regulators/src/rule.hpp
index 25be1e9..3fb21a6 100644
--- a/phosphor-regulators/src/rule.hpp
+++ b/phosphor-regulators/src/rule.hpp
@@ -52,7 +52,7 @@
      *
      * @param id unique rule ID
      */
-    Rule(const std::string& id) : id{id}
+    explicit Rule(const std::string& id) : id{id}
     {
     }