Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-power / 03e2a02869b7d2208396c7334eea3e2333a6a16b
commit03e2a02869b7d2208396c7334eea3e2333a6a16b[log] [tgz]
authorFaisal Awada <faisal@us.ibm.com>Wed Nov 15 20:31:13 2023 +0000
committerFaisal Awada <faisal@us.ibm.com>Fri Nov 17 20:42:39 2023 +0000
treec49587491fdafeddfdc5d5fd705b850f01c4ddde
parentb7131a12ee603264a90b55dd7afde929434424e9 [diff]
psu-ng: Fixed PSU monitor app not to report error on valid configuration

Modified the PSU monitor app not to report error when the PSU is not present and the PSU validation timer active; or PSU present but we don't have infomation from Entity Manager (EM),the application will have to wait for EM info while the validation timer active before reporting error.

Note: The fix was done due to sometime Entity manager gets busy may delay to post PSU information which causes this application to post invalid PSU error.

Tested:
    1 - On system with 4 PSUs and chassis powered on, with modified code
        to allow  3 PSU interfaces and ignore the 4th interface.
      * Verified error reported after the validation timer expired.
   2 - On system requires 4 PSUs I removed 1 PSU, powered on the chassis
       rebooted BMC with the fix.
      * Verified the system reported error after the validation timer
        expired.
   3 - Ran a good machine pass with the fix and verified no error
       reported.

Change-Id: I7c99f64b589fbe7db86cb16b720cf3ff9b62baab
Signed-off-by: Faisal Awada <faisal@us.ibm.com>
1 file changed
tree: c49587491fdafeddfdc5d5fd705b850f01c4ddde
  1. cold-redundancy/
  2. example/
  3. org/
  4. phosphor-power-sequencer/
  5. phosphor-power-supply/
  6. phosphor-regulators/
  7. power-sequencer/
  8. power-supply/
  9. services/
  10. subprojects/
  11. test/
  12. tools/
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. device.hpp
  17. device_monitor.hpp
  18. elog-errors.hpp
  19. file_descriptor.hpp
  20. gpio.cpp
  21. gpio.hpp
  22. LICENSE
  23. meson.build
  24. meson.options
  25. names_values.hpp
  26. OWNERS
  27. pmbus.cpp
  28. pmbus.hpp
  29. README.md
  30. types.hpp
  31. utility.cpp
  32. utility.hpp
README.md

Overview

This repository contains applications for configuring and monitoring devices that deliver power to the system.

  • cold-redundancy: Application that makes power supplies work in Cold Redundancy mode and rotates them at intervals.
  • phosphor-power-sequencer: Applications for configuring and monitoring power sequencer and related devices that support JSON-driven configuration.
  • phosphor-power-supply: Next generation power supply monitoring application.
  • phosphor-regulators: JSON-driven application that configures and monitors voltage regulators.
  • power-sequencer: A power sequencer monitoring application.
  • power-supply: Original power supply monitoring application.
  • tools/power-utils: Power supply utilities.

Build

To build all applications in this repository:

  meson build
  ninja -C build

To clean the repository and remove all build output:

  rm -rf build

You can specify meson options to customize the build process. For example, you can specify:

  • Which applications to build and install.
  • Application-specific configuration data, such as power sequencer type.
  • Whether to build tests.

Power Supply Monitor and Util JSON config

Several applications in this repository require a PSU JSON config to run. The JSON config file provides information for:

  • Where to access the pmbus attributes
  • Which attribute file in pmbus maps to which property and interface in D-Bus
  • Which kernel device directory is used on which PSU

There is an example psu.json to describe the necessary configurations.

  • inventoryPMBusAccessType defines the pmbus access type, which tells the service which sysfs type to use to read the attributes. The possible values are:
    • Base: The base dir, e.g. /sys/bus/i2c/devices/3-0069/
    • Hwmon: The hwmon dir, e.g. /sys/bus/i2c/devices/3-0069/hwmon/hwmonX/
    • Debug: The pmbus debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/
    • DeviceDebug: The device debug dir, e.g. '/sys/kernel/debug/./`
    • HwmonDeviceDebug: The hwmon device debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/cffps1/
  • fruConfigs defines the mapping between the attribute file and the FRU inventory interface and property. The configuration example below indicates that the service will read part_number attribute file from a directory specified by the above pmbus access type, and assign to PartNumber property in xyz.openbmc_project.Inventory.Decorator.Asset interface.
      "fruConfigs": [
    {
      "propertyName": "PartNumber",
      "fileName": "part_number",
      "interface": "xyz.openbmc_project.Inventory.Decorator.Asset"
    }
  ]
  • psuDevices defines the kernel device dir for each PSU in inventory. The configuration example below indicates that powersupply0's device is located in /sys/bus/i2c/devices/3-0069.
      "psuDevices": {
    "/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply0" : "/sys/bus/i2c/devices/3-0069",
  }