Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-power / 38ed88d66652c0927ffdc38fe9b0f47fd62e7015
commit38ed88d66652c0927ffdc38fe9b0f47fd62e7015[log] [tgz]
authorShawn McCarney <shawnmm@us.ibm.com>Wed Dec 11 12:26:09 2019 -0600
committerShawn McCarney <shawnmm@us.ibm.com>Thu Dec 12 16:48:20 2019 -0600
tree27284a30e0b3267d4ddc7817a0fb5eb1107468a3
parentd45a9a6d80b8172e8d1c7b3019dc6d75d23e3547 [diff]
i2c: Cache adapter functionality

Enhance the I2CDevice class to cache the I2C adapter functionality
value.  The adapter functionality value should not change while the
device interface is open.

Caching the functionality value will reduce the number of ioctl() calls
by 50% when doing long sequences of I2C operations.

Tested:
* Verified adapter functionality value is cached
* Verified read() method works on a Witherspoon
* Verified close() method discards the cached functionality value

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I2b17d91ae4e21aaf52cd4cec9eddb5aab7be37e5
2 files changed
tree: 27284a30e0b3267d4ddc7817a0fb5eb1107468a3
  1. example/
  2. org/
  3. phosphor-regulators/
  4. power-sequencer/
  5. power-supply/
  6. services/
  7. test/
  8. tools/
  9. .clang-format
  10. .gitignore
  11. argument.hpp
  12. device.hpp
  13. device_monitor.hpp
  14. elog-errors.hpp
  15. file.hpp
  16. gpio.cpp
  17. gpio.hpp
  18. LICENSE
  19. MAINTAINERS
  20. meson.build
  21. meson_options.txt
  22. names_values.hpp
  23. pmbus.cpp
  24. pmbus.hpp
  25. README.md
  26. types.hpp
  27. utility.cpp
  28. utility.hpp
README.md

Code for detecting and analyzing power faults on Witherspoon.

To Build

To build this package, do the following steps:

    1. meson build
    2. ninja -C build

To clean the repository again run `rm -rf build`.

Power Supply Monitor and Util JSON config

Several applications in this repository require a PSU JSON config to run. The JSON config file provides information for:

  • Where to access the pmbus attributes
  • Which attribute file in pmbus maps to which property and interface in D-Bus
  • Which kernel device directory is used on which PSU

There is an example psu.json to describe the necessary configurations.

  • inventoryPMBusAccessType defines the pmbus access type, which tells the service which sysfs type to use to read the attributes. The possible values are:
    • Base: The base dir, e.g. /sys/bus/i2c/devices/3-0069/
    • Hwmon: The hwmon dir, e.g. /sys/bus/i2c/devices/3-0069/hwmon/hwmonX/
    • Debug: The pmbus debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/
    • DeviceDebug: The device debug dir, e.g. '/sys/kernel/debug/./`
    • HwmonDeviceDebug: The hwmon device debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/cffps1/
  • fruConfigs defines the mapping between the attribute file and the FRU inventory interface and property. The configuration example below indicates that the service will read part_number attribute file from a directory specified by the above pmbus access type, and assign to PartNumber property in xyz.openbmc_project.Inventory.Decorator.Asset interface.
      "fruConfigs": [
    {
      "propertyName": "PartNumber",
      "fileName": "part_number",
      "interface": "xyz.openbmc_project.Inventory.Decorator.Asset"
    }
  ]
  • psuDevices defines the kernel device dir for each PSU in inventory. The configuration example below indicates that powersupply0's device is located in /sys/bus/i2c/devices/3-0069.
      "psuDevices": {
    "/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply0" : "/sys/bus/i2c/devices/3-0069",
  }