commit 5135df6333f7f2a8b328f148c6443727e15b7873
author Shawn McCarney <shawnmm@us.ibm.com> Wed Apr 28 15:53:24 2021 -0500
committer Shawn McCarney <shawnmm@us.ibm.com> Thu Apr 29 00:32:23 2021 -0500
tree f662d0d8aad98c79d2c40871d835d1be8c1bed56
parent 8279a11d6485071cfd519e5b280a9039114eb141

regulators: Remove SensorReading data type

Remove the SensorReading data type defined in pmbus_utils.hpp and used
in several locations.  This data type is no longer needed.

The original design was for sensor readings to be accumulated in the
ActionEnvironment while the PMBus actions were being executed.  Then all
the sensor readings for a voltage rail would be published on D-Bus at
the same time.

The current design is for sensor readings to be immediately published on
D-Bus as they are read using the new Sensors service.  They no longer
need to be accumulated in the ActionEnvironment.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Ib61a07b5a7f58be3e2dae540ffb4d5128636b7c0

phosphor-regulators/test/actions/pmbus_read_sensor_action_tests.cpp

diff --git a/phosphor-regulators/test/actions/pmbus_read_sensor_action_tests.cpp b/phosphor-regulators/test/actions/pmbus_read_sensor_action_tests.cpp
index d0f1398..09edfe7 100644
--- a/phosphor-regulators/test/actions/pmbus_read_sensor_action_tests.cpp
+++ b/phosphor-regulators/test/actions/pmbus_read_sensor_action_tests.cpp
@@ -122,10 +122,14 @@
         std::optional<int8_t> exponent{};
         PMBusReadSensorAction action{type, command, format, exponent};
         EXPECT_EQ(action.execute(env), true);
-        EXPECT_EQ(env.getSensorReadings().size(), 1);
-        EXPECT_EQ(env.getSensorReadings()[0].type,
-                  pmbus_utils::SensorValueType::iout);
-        EXPECT_DOUBLE_EQ(env.getSensorReadings()[0].value, 11.5);
+        /**
+         * TODO: Replace with EXPECT calls using MockSensors
+         *
+         *  EXPECT_EQ(env.getSensorReadings().size(), 1);
+         *  EXPECT_EQ(env.getSensorReadings()[0].type,
+         *            pmbus_utils::SensorValueType::iout);
+         *  EXPECT_DOUBLE_EQ(env.getSensorReadings()[0].value, 11.5);
+         */
     }
     catch (...)
     {
@@ -167,10 +171,14 @@
         std::optional<int8_t> exponent{3};
         PMBusReadSensorAction action{type, command, format, exponent};
         EXPECT_EQ(action.execute(env), true);
-        EXPECT_EQ(env.getSensorReadings().size(), 1);
-        EXPECT_EQ(env.getSensorReadings()[0].type,
-                  pmbus_utils::SensorValueType::vout);
-        EXPECT_DOUBLE_EQ(env.getSensorReadings()[0].value, 16);
+        /**
+         * TODO: Replace with EXPECT calls using MockSensors
+         *
+         * EXPECT_EQ(env.getSensorReadings().size(), 1);
+         * EXPECT_EQ(env.getSensorReadings()[0].type,
+         *           pmbus_utils::SensorValueType::vout);
+         * EXPECT_DOUBLE_EQ(env.getSensorReadings()[0].value, 16);
+         */
     }
     catch (...)
     {
@@ -213,10 +221,14 @@
         std::optional<int8_t> exponent{};
         PMBusReadSensorAction action{type, command, format, exponent};
         EXPECT_EQ(action.execute(env), true);
-        EXPECT_EQ(env.getSensorReadings().size(), 1);
-        EXPECT_EQ(env.getSensorReadings()[0].type,
-                  pmbus_utils::SensorValueType::vout_peak);
-        EXPECT_DOUBLE_EQ(env.getSensorReadings()[0].value, 0.232421875);
+        /**
+         * TODO: Replace with EXPECT calls using MockSensors
+         *
+         * EXPECT_EQ(env.getSensorReadings().size(), 1);
+         * EXPECT_EQ(env.getSensorReadings()[0].type,
+         *           pmbus_utils::SensorValueType::vout_peak);
+         * EXPECT_DOUBLE_EQ(env.getSensorReadings()[0].value, 0.232421875);
+         */
     }
     catch (...)
     {